diff options
| author | florian | 2018-08-19 12:31:41 +0000 |
|---|---|---|
| committer | Wynn Wolf Arbor | 2020-05-24 12:33:55 +0200 |
| commit | bf949ae69e139767ee5bb4b518d99fdb93037dd2 (patch) | |
| tree | 9a4d66c2f6a1326dccd60eab8b6640b68d297e0c | |
| parent | 157a1e913ca57b41dbb048c07181a99aa7eb2c7c (diff) | |
| download | slowcgi-bf949ae69e139767ee5bb4b518d99fdb93037dd2.tar.gz | |
Call daemon with 0 as first argument so that it changes the cwd to /. It is not a problem in slowcgi since it calls chroot(2) and then chdir(2) shortly afterwards but hopefully prevents copying code into daemons where it does matter. Problem first observed by dlg in ntpd(8) which keeps sitting in the directory from where it was started which might for example prevent an unmount. Discussed with deraadt@
| -rw-r--r-- | slowcgi.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -1,4 +1,4 @@ -/* $OpenBSD: slowcgi.c,v 1.53 2018/08/13 16:54:50 florian Exp $ */ +/* $OpenBSD: slowcgi.c,v 1.54 2018/08/19 12:31:41 florian Exp $ */ /* * Copyright (c) 2013 David Gwynne <dlg@openbsd.org> * Copyright (c) 2013 Florian Obser <florian@openbsd.org> @@ -323,7 +323,7 @@ main(int argc, char *argv[]) if (geteuid() != 0) errx(1, "need root privileges"); - if (!debug && daemon(1, 0) == -1) + if (!debug && daemon(0, 0) == -1) err(1, "daemon"); if (!debug) { |