diff options
| author | Wolfgang Müller | 2022-11-19 17:44:00 +0100 |
|---|---|---|
| committer | Wolfgang Müller | 2022-11-19 17:44:00 +0100 |
| commit | a2ab0abdbb2d98cc9f458c03213bc22cdc77d6db (patch) | |
| tree | 71664bf8730dac72d1ca9dc6e32b6ed11376bff6 /TODO | |
| parent | dd8daea59e7f93c8bc17627e5573bd7f7191319b (diff) | |
| download | weltschmerz-a2ab0abdbb2d98cc9f458c03213bc22cdc77d6db.tar.gz | |
Use spawn_async instead of spawn_sync
The 'spawn_sync' function has been deprecated for a very long time now,
but we could never use its intended replacement as its Vala bindings
were broken [1]. The underlying problem had been identified in [2] a
while ago, but has only been recently fixed in [3] and is now available
in Vala's 0.56 branch.
Since we rely on the child PID as a fallback for opinionated users or
shells that are unaware of OSC 7, we have to pass a callback function to
the 'spawn_async' call so we can capture the PID which is no longer
supplied by the method itself.
[1] https://gitlab.gnome.org/GNOME/vte/issues/227
[2] https://gitlab.gnome.org/GNOME/vala/-/issues/721
[3] https://gitlab.gnome.org/GNOME/vala/-/commit/f058e9e828f494ebf8d60cabff7999f219048623
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 7 |
1 files changed, 0 insertions, 7 deletions
@@ -7,13 +7,6 @@ [1] https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html#gtk-image-menu-item-new -- Upstream recommends spawn_async() instead of spawn_sync(), but the bindings - for it are erroneous. - - See: https://gitlab.gnome.org/GNOME/vala/issues/721 - https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/168 - https://gitlab.gnome.org/GNOME/vte/issues/227 - - The upstream GTK devel branch has dropped some X11-specific APIs, including the interface for urgency hints. Eventually, this feature will have to be removed from weltschmerz too. |