| Commit message (Collapse) | Author | Lines |
|---|
|
Since repos.avail/ is a bind mount of the root directory containing all
of the users git repositories, changing permissions on it will also
change permissions on the underlying root directory. This should not
happen.
As this action was only really added for paranoia, and the git
repositories themselves will have proper permissions set such that the
cgit process can't read what it is not allowed to, just remove it.
|
|
Both bind_* functions remove the SKEIN_CGIT_ROOT prefix from its log
messages in an effort to remove redundant information. With commit
efdbb04 ("skein-infra: Rename instances/ to home/") however, it is no
longer clear from the path alone that a path under SKEIN_CGIT_ROOT is
being operated upon. Use the full path in the log message to resolve
this.
The logging aliases ladd() and ldel() are only used in the respective
bind_mount() and bind_umount() functions and we don't expect this to
change any time soon. Rename log() to log_mount() and call the latter
directly from within both bind_* functions to improve clarity.
|
|
Instead of relying on positional parameters, bind_umount() still
referenced "$i" from the function it initially came from, teardown().
This worked because the variable was still in scope, but is arguably
unclean and confusing.
Use positional parameters for bind_umount() instead, like bind_mount()
does.
|
|
Users might easily confuse the per-instance repos/ directory with the
mount point that contains all available repositories for a given user.
Therefore, be more clear about the purpose of the mount point and rename
it.
|
|
The instances/ directory does not directly contain user instances (but
instead directories for each user owning at least one instance), so use
home/ as a more fitting name.
|
|
Be more clear about the purpose of this script and rename it to
"skein-infra" since users might expect a program carrying "chroot" in
its name to enter or otherwise manage a chroot.
Additionally, use a consistent format for the environment variables
controlling the locations of the cgit chroot and git repositories.
|
|
|
