aboutsummaryrefslogtreecommitdiffstatshomepage
Commit message (Collapse)AuthorAgeLines
* main: Handle BrokenPipeError cleanlyWolfgang Müller2021-05-04-1/+1
| | | | | | | Whilst not recommended, quarg may happen to be used in conjunction with head(1), tail(1), or any other program that will send SIGPIPE. This commit makes sure that we close the database connection properly if we receive that signal.
* Revert "Rename 'prefix' to 'umode'"Wolfgang Müller2021-05-04-4/+4
| | | | | | | | | | | | This reverts commit efde2954efd636a617702ee1aefb8b1247c9cc5b. After some more consideration, we feel that referring to modes here is misleading and confusing. Compromise by keeping the -m flag, but changing the variable name back to 'prefix' and making clear in the help message that quarg will match against the "channel membership prefix", a term that is used in the Modern IRC Client Protocol specification [1] [1] https://modern.ircdocs.horse/#channel-membership-prefixes
* main: Handle user interrupts more nicelyWolfgang Müller2021-05-03-0/+4
| | | | | | Users may want to cancel queries that are taking a long time. This commit ensures that the database is left in a clean state and that quarg exits immediately after closing the database connection.
* main: Handle SQLAlchemy errors more nicelyWolfgang Müller2021-05-03-6/+9
| | | | | | | | | Instead of giving the user a screen full of backtraces, catch any errors SQLAlchemy can run into when preparing or executing the query and report only the error message to the user. We include the print loop in the try/except block because an upcoming commit will add a handler for KeyboardInterrupt.
* main: Split run_query into prepare_query and time_queryWolfgang Müller2021-05-03-7/+8
| | | | | | | This commit cleanly separates the preparation, execution, and timing of a query. When preparing this commit, we realized that the preparation of the query was included in the timer calculation. This should not have been the case and has been fixed.
* formatter: Use custom time format when printing message timestampsWolfgang Müller2021-05-03-3/+4
| | | | | | | | | | | | Up until now we were relying on isoformat() to format timestamps when printing messages, since that was a simple shortcut to a well-known format. With the addition of timezone support, however, isoformat() started adding the timezone offset to the timestamp. This makes timestamps unnecessarily verbose. This commit has the formatter use a custom ISO 8601-esque time format instead which restores the behaviour previous to the introduction of timezones.
* Remove the INFO message typeWolfgang Müller2021-05-03-2/+2
| | | | | | Quassel uses this message type only for very rare and mostly irrelevant informational messages that users will most likely not be wanting to search for.
* Add option to specify the order for printed messagesWolfgang Müller2021-05-02-5/+18
| | | | | As mentioned in the previous commit, this change makes it possible to select the first or last N matches in conjunction with the -l flag.
* Add option to limit the number of matchesWolfgang Müller2021-05-02-3/+8
| | | | | | | | | This is useful if the user already expects a lot of matches but is only interested in a limited number of them. An upcoming commit will introduce the option to have quarg list matches in ascending or descending order (currently we do not pick a default - effectively listing matches in ascending timestamp order), making it possible to select the first or last N matches.
* Handle timezones correctlyWolfgang Müller2021-05-02-3/+25
| | | | | | | | | | | | | | | | | | | | Quassel uses UTC message timestamps in its database, but does not save any timezone information along with them. Up until now, we were reading those timestamps from the database naively - resulting in datetime objects that could not be identified as UTC. The same happened with timestamps we got from dateutil.isoparse. If the user did not specify an offset explicitly, the timestamp would be parsed and passed to the program "as is", effectively being interpreted as UTC because they were compared to database timestamps. This commit will ensure that the correct timezone is saved for every datetime object we encounter. Timestamps from the database are marked as UTC. If the user does not explicitly specify an offset, the timestamp is assumed to be in local time. Furthermore, when printing out message timestamps, make sure to convert them to the user's local timezone first.
* tables: Fix up a note, add another for the Network tableWolfgang Müller2021-05-01-2/+4
|
* actions: Have ParseEnum print a list of possible values on errorWolfgang Müller2021-05-01-1/+3
| | | | | This will save the user a look at the program's manual and makes using the program more convenient.
* actions: Allow specifying a unit suffix for --aroundWolfgang Müller2021-05-01-4/+16
| | | | | | | | Up until now it was only possible to give --around a range specified in hours. Since most discussions on IRC tend not to last for multiple hours, and one may only be interested in a few minutes of logs, this commit adds the ability to specify a unit suffix that takes either 'm' for minutes or 'h' for hours. If it is missing, 'h' is assumed.
* actions: Specify where a parse error happened for --aroundWolfgang Müller2021-05-01-1/+1
| | | | | Previously quarg would simply echo the error message without any context, making it harder to find exactly which option caused it.
* actions: Error out when the range for --around is missingWolfgang Müller2021-05-01-0/+3
| | | | | | Previously this case was handled by the int() cast in the try/except block but resulted in a confusing error message. Make clear to the user what exactly went wrong.
* main: Improve help messageWolfgang Müller2021-05-01-19/+21
| | | | | | | | | | Group message matching into two main parts (context and timestamps) and simplify the help text for each option. Rename 'query' to 'keyword' to avoid confusion with SQL queries and IRC queries. Additionally, change some option flags to better communicate the type of option (upper-case ones are used less frequently) or to make sure no future option clashes with a less-frequently used one.
* Rename 'prefix' to 'umode'Wolfgang Müller2021-04-29-4/+4
| | | | | | | | | Whilst still not perfect, 'umode' signals more closely what this option does. We do not plan to add matching on channel modes, so -m should be fine here. The original name for this option came from the column in the backlog table, 'senderprefixes'.
* main: Adjust help message for -u to match the restWolfgang Müller2021-04-29-1/+1
|
* types: Ignore unused or nonsensical types and flagsWolfgang Müller2021-04-28-13/+9
| | | | | | | | | | | | | | | As this program interacts with quassel's database only, it does not have access to any state the UI carries. Some types (such as DAYCHANGE, IGNORED, BACKLOG, GROUP) seem to not be represented in the database at all, most likely only set on data structures in memory by the quasselclient application. Some others make no real sense to include in an application like this, which is more focused on human-readable messages and circumstances. For example, INVALID, REDIRECTED, SERVERMSG, etc are all of less concern to the average user than, say, matching on nicknames or buffers. Therefore, ignore all of these until we find a good use for them.
* actions: Remove FIXME regarding / as separator in --aroundWolfgang Müller2021-04-28-1/+0
| | | | Using / here should be fine.
* filters: Rename time_from and time_toWolfgang Müller2021-04-28-6/+6
| | | | | These make more sense and are clearer if they're named after the command line arguments that trigger them.
* main: Make --around mutually exclusive with either --after or --beforeWolfgang Müller2021-04-28-2/+6
| | | | | | Using --around does not make much sense if there is also a match on --after or --before, since the range in --around would most certainly take precedence. Disallow this behaviour.
* main: Make --joined and --no-joined mutually exclusiveWolfgang Müller2021-04-28-3/+4
| | | | | | Sadly we can not yet rely on BooleanOptionalAction, since that was only added in Python 3.9. Also remove the FIXME note, it seems that boolean options like this trigger a standard default setting with argparse.
* formatter: Make parameter name for format_netsplit clearerWolfgang Müller2021-04-28-6/+6
|
* Move Actions to their own fileWolfgang Müller2021-04-28-68/+71
|
* Split errx and parse_isodate out into utils.pyWolfgang Müller2021-04-28-14/+16
| | | | | We're going to need this for an upcoming commit that moves all argparse.Action classes to its own file.
* main: Improve readability of collect_predicatesWolfgang Müller2021-04-28-10/+19
| | | | | Instead of adding another indentation level, exit early if a value or a key can be ignored.
* formatter: Implement truncation of joined/quit users in netsplitsWolfgang Müller2021-04-28-13/+14
| | | | | | | The list of users that have quit or joined after a netsplit can become quite large. Quassel itself cuts reporting off after printing 15 users, so let's follow that. Note that this will not affect queries - the search is performed against the whole netsplit message.
* formatter: Use functools.partial to simplify the formatterWolfgang Müller2021-04-28-32/+9
| | | | | | | | Instead of defining a function for every message format that trivially returns an f-string, have a generic partially-applied helper function that applies the Message object as a dictionary to the format() function. That way, we can inline the formatter definitions directly in the FORMATTERS dictionary.
* Initial prototypeWolfgang Müller2021-04-28-0/+522