From 08c2bcb952a0abbead263dcb0026eab58e736e1d Mon Sep 17 00:00:00 2001 From: Raffaele <1770381+rafspiny@users.noreply.github.com> Date: Tue, 21 Apr 2020 03:07:39 +0200 Subject: [PATCH] Quote LDFLAGS (#1995) Make sure that `extldflags` is quoted so that LDFLAGS containing spaces won't break the build command. Close #1994 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 037b19b..60283d0 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ ROOT_DIR := $(shell dirname $(MAKEFILE)) SOURCES := $(wildcard *.go src/*.go src/*/*.go) $(MAKEFILE) REVISION := $(shell git log -n 1 --pretty=format:%h -- $(SOURCES)) -BUILD_FLAGS := -a -ldflags "-X main.revision=$(REVISION) -w -extldflags=$(LDFLAGS)" -tags "$(TAGS)" +BUILD_FLAGS := -a -ldflags "-X main.revision=$(REVISION) -w '-extldflags=$(LDFLAGS)'" -tags "$(TAGS)" BINARY32 := fzf-$(GOOS)_386 BINARY64 := fzf-$(GOOS)_amd64 -- 2.26.2