summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWynn Wolf Arbor2020-10-21 15:07:19 +0200
committerWynn Wolf Arbor2020-10-21 15:07:19 +0200
commit9eb2c3d1535399317037fa6d490b361a3295af4e (patch)
tree132c436456d719b158246df59abb5c1677faab2e
parentf6c112d3883ea6bb77c4373ca3bc65b0d4b5c774 (diff)
downloadportage-roles-9eb2c3d1535399317037fa6d490b361a3295af4e.tar.gz
app-fava: Drop old patch
app-office/fava-1.16, which includes this patch, now exists in the pramantha tree.
Diffstat (limited to '')
-rw-r--r--app-fava/patches/app-office/fava-1.15/0001-Fix-drag-and-drop-events-not-being-processed.patch62
1 files changed, 0 insertions, 62 deletions
diff --git a/app-fava/patches/app-office/fava-1.15/0001-Fix-drag-and-drop-events-not-being-processed.patch b/app-fava/patches/app-office/fava-1.15/0001-Fix-drag-and-drop-events-not-being-processed.patch
deleted file mode 100644
index 7eab6ac..0000000
--- a/app-fava/patches/app-office/fava-1.15/0001-Fix-drag-and-drop-events-not-being-processed.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 4d2817c9915b12b82e26f80f4466e8a6d2da1b1a Mon Sep 17 00:00:00 2001
-From: Wynn Wolf Arbor <wolf@oriole.systems>
-Date: Mon, 29 Jun 2020 19:31:30 +0200
-Subject: [PATCH] Fix drag and drop events not being processed
-
-When uploading documents via drag and drop, we want to make sure that
-the DragEvent is only processed if it references dragged files. This is
-done by checking the length of the 'event.dataTransfer.files' list.
-
-In a5eec6d6 (support attaching (already uploaded) documents to txns,
-2020-05-16), a check for dragged URLs was added and the validation of
-'event.dataTransfer.files' was moved from 'drop()' to 'dragover()'.
-
-The HTML Living Standard defines a 'drag data store mode' [1], which
-governs read and write access to the drag data store. Specifically, if
-the drag data store is in protected mode, the 'files' attribute must
-return the empty list [2].
-
-Before commit a5eec6d6, 'event.dataTransfer.files' was accessed in the
-'drop' event, with the drag data store in read-only mode. Now, however,
-we access it in the 'dragover' event, with the drag data store in
-protected mode. The validation in 'dragover()' therefore fails because
-'event.dataTransfer.files' is empty. For browsers that are compliant
-with the HTML Living Standard, Fava does not process any drag and drop
-events.
-
-The standard also defines a 'DataTransferItemList' interface [3], whose
-'length' attribute [4] can be used to get the number of items in the
-drag data store. This is possible even in protected mode, but some
-browsers (notably Safari) do not implement this yet [5].
-
-Instead, similar to checking for URLs, solve this problem by checking
-whether the 'types' list includes entries of type "Files". [6]
-
-Closes #1122.
-
-[1] https://html.spec.whatwg.org/multipage/dnd.html#drag-data-store-mode
-[2] https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-files
-[3] https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface
-[4] https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransferitemlist-length
-[5] https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/items#Browser_compatibility
-[6] https://html.spec.whatwg.org/multipage/dnd.html#concept-datatransfer-types
----
- src/fava/static/app.js | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/fava/static/app.js b/src/faca/static/app.js
-index ce95378..1f35e0b 100644
---- a/src/fava/static/app.js
-+++ b/src/fava/static/app.js
-@@ -30325,7 +30325,7 @@
- */
- function dragover(event, closestTarget) {
- if (event.dataTransfer &&
-- (event.dataTransfer.files.length ||
-+ (event.dataTransfer.types.includes("Files") ||
- event.dataTransfer.types.includes("text/uri-list"))) {
- closestTarget.classList.add("dragover");
- event.preventDefault();
---
-2.27.0
-