From 9e7ede5afcbc99a3670ee8232ecfbce79da0dde8 Mon Sep 17 00:00:00 2001 From: Wolfgang Müller Date: Wed, 6 Nov 2024 12:34:48 +0100 Subject: Avoid shadowing builtins This will hopefully avoid nasty surprises in the future. It's easy to check since there is already a ruff linter [1] for it which this commit also enables. Make sure not to complain about exit() [2] since that is only for interactive use and shouldn't be called in programs anyway. [1] https://docs.astral.sh/ruff/rules/builtin-attribute-shadowing/ [2] https://docs.python.org/3.12/library/constants.html#exit --- later | 4 ++-- ruff.toml | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/later b/later index 5b82a6e..a5a25c8 100755 --- a/later +++ b/later @@ -25,8 +25,8 @@ def exit(message=""): sys.exit(f"later: {message}" if message else 0) -def get_xdg(type, fallback): - env = f"XDG_{type.upper()}_HOME" +def get_xdg(directory, fallback): + env = f"XDG_{directory.upper()}_HOME" if env in os.environ: return os.environ[env] return os.path.expanduser(fallback) diff --git a/ruff.toml b/ruff.toml index 2a53694..d00d37e 100644 --- a/ruff.toml +++ b/ruff.toml @@ -8,7 +8,11 @@ select = [ "W", # pycodestyle "I", # isort "UP", # pyupgrade + "A", # flake8-builtins "B", # flake8-bugbear "SIM", # flake8-simplify "FURB" # refurb ] + +[lint.flake8-builtins] +builtins-ignorelist = ["exit"] -- cgit v1.2.3-2-gb3c3