From ddeeb372250409da1f31a0522fb715e552c1f450 Mon Sep 17 00:00:00 2001 From: Wolfgang Müller Date: Mon, 25 Mar 2024 21:27:36 +0100 Subject: backend: Report Archive size as float GraphQL integers are 32-bit as per spec [1] [2]. Implementations may therefore error on large numbers. Since an archive's size can reasonably exceed this value, make sure to report it as a float instead. [1] https://graphql.org/learn/schema/ [2] https://github.com/graphql/graphql-js/issues/292#issuecomment-186702763 --- frontend/src/gql/graphql.ts | 4 ++-- src/hircine/api/types.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/gql/graphql.ts b/frontend/src/gql/graphql.ts index 139068c..4d09e75 100644 --- a/frontend/src/gql/graphql.ts +++ b/frontend/src/gql/graphql.ts @@ -76,7 +76,7 @@ export type Archive = { organized: Scalars['Boolean']['output']; pageCount: Scalars['Int']['output']; path: Scalars['String']['output']; - size: Scalars['Int']['output']; + size: Scalars['Float']['output']; }; export type ArchiveFilter = { @@ -423,7 +423,7 @@ export type FullArchive = { pageCount: Scalars['Int']['output']; pages: Array; path: Scalars['String']['output']; - size: Scalars['Int']['output']; + size: Scalars['Float']['output']; }; export type FullComic = { diff --git a/src/hircine/api/types.py b/src/hircine/api/types.py index b9fe0e7..bbd13fa 100644 --- a/src/hircine/api/types.py +++ b/src/hircine/api/types.py @@ -81,7 +81,7 @@ class FilterResult(Generic[T]): class Archive(MixinName, MixinOrganized, Base): cover: "Image" path: str - size: int + size: float page_count: int def __init__(self, model): -- cgit v1.2.3-2-gb3c3