summaryrefslogtreecommitdiffstatshomepage
path: root/tests/scrapers/test_scraper_utils.py
diff options
context:
space:
mode:
authorWolfgang Müller2024-11-15 15:52:00 +0100
committerWolfgang Müller2024-11-15 15:52:00 +0100
commit36ede4eb05c508b727e41a0f43cc3c88c7a94633 (patch)
treef7e1af7b361d4bc4087de9c90d14b2e3ff19c137 /tests/scrapers/test_scraper_utils.py
parent05f139746c38dd490d10bd3593d6e31ea0516df2 (diff)
downloadhircine-36ede4eb05c508b727e41a0f43cc3c88c7a94633.tar.gz
backend/lint: Do not shadow certain builtins
This commit enables ruff's flake8-builtin linter that emits warnings when builtin functions are shadowed. This is useful for builtins like "dict", "list", or "str" which we use often. Given the nature of this program we historically rely a lot on the usage of "id", "hash", and "filter" as variable names which also shadow Python builtins. For now let's ignore those, we have not used any of them in our code and the impact to the codebase would be considerable. This might be revisited in the future.
Diffstat (limited to 'tests/scrapers/test_scraper_utils.py')
-rw-r--r--tests/scrapers/test_scraper_utils.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/tests/scrapers/test_scraper_utils.py b/tests/scrapers/test_scraper_utils.py
index 4b02aad..30b9796 100644
--- a/tests/scrapers/test_scraper_utils.py
+++ b/tests/scrapers/test_scraper_utils.py
@@ -8,23 +8,23 @@ from hircine.scraper.utils import open_archive_file, parse_dict
def test_parse_dict():
- dict = {
+ data = {
"scalar": "foo",
"list": ["bar", "baz"],
"dict": {"nested_scalar": "qux", "nested_list": ["plugh", "xyzzy"]},
}
- def id(type):
- return lambda item: f"{type}_{item}"
+ def annotate(tag):
+ return lambda item: f"{tag}_{item}"
parsers = {
- "scalar": id("scalar"),
- "list": id("list"),
- "dict": {"nested_scalar": id("scalar"), "nested_list": id("list")},
- "missing": id("missing"),
+ "scalar": annotate("scalar"),
+ "list": annotate("list"),
+ "dict": {"nested_scalar": annotate("scalar"), "nested_list": annotate("list")},
+ "missing": annotate("missing"),
}
- assert [f() for f in parse_dict(parsers, dict)] == [
+ assert [f() for f in parse_dict(parsers, data)] == [
"scalar_foo",
"list_bar",
"list_baz",