From f069a19b033cc9adb37dea328d36f15bcdc0c892 Mon Sep 17 00:00:00 2001 From: oga Date: Thu, 15 Jan 2009 17:23:12 +0000 Subject: On startup, don't leak memory when we enumerate existing windows. The behaviour until now was to ask X for the windows name (which is malloced) then drop that on the floor and do nothing with it. Skip this foolery and just skip the window. I don't believe I never noticed this before! "you can has ok" okan@ --- calmwm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'calmwm.c') diff --git a/calmwm.c b/calmwm.c index 118829b..f0833c0 100644 --- a/calmwm.c +++ b/calmwm.c @@ -15,7 +15,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $Id: calmwm.c,v 1.31 2008/12/03 23:55:46 oga Exp $ + * $Id: calmwm.c,v 1.32 2009/01/15 17:23:12 oga Exp $ */ #include "headers.h" @@ -229,11 +229,8 @@ x_setupscreen(struct screen_ctx *sc, u_int which) for (i = 0; i < nwins; i++) { XGetWindowAttributes(X_Dpy, wins[i], &winattr); if (winattr.override_redirect || - winattr.map_state != IsViewable) { - char *name; - XFetchName(X_Dpy, wins[i], &name); + winattr.map_state != IsViewable) continue; - } client_new(wins[i], sc, winattr.map_state != IsUnmapped); } XFree(wins); -- cgit v1.2.3-2-gb3c3