From 1fd2fe716484cde85f4942921795018399b60bf4 Mon Sep 17 00:00:00 2001 From: tobias Date: Sat, 25 Apr 2020 20:07:28 +0000 Subject: Fixed memory leak in xu_get_strprop. If a client calls XSetTextProperty for a window to clear all its properties, then allocated memory within libX11 is not freed. OK okan@ --- xutil.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xutil.c b/xutil.c index 01a7dc5..8d92b50 100644 --- a/xutil.c +++ b/xutil.c @@ -15,7 +15,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: xutil.c,v 1.112 2020/03/24 14:47:29 okan Exp $ + * $OpenBSD: xutil.c,v 1.113 2020/04/25 20:07:28 tobias Exp $ */ #include @@ -73,8 +73,10 @@ xu_get_strprop(Window win, Atom atm, char **text) { *text = NULL; XGetTextProperty(X_Dpy, win, &prop, atm); - if (!prop.nitems) + if (!prop.nitems) { + XFree(prop.value); return 0; + } if (Xutf8TextPropertyToTextList(X_Dpy, &prop, &list, &nitems) == Success && nitems > 0 && *list) { -- cgit v1.2.3-2-gb3c3