From 0be19ed3a4dda428d7845aa2493138db0a4c353c Mon Sep 17 00:00:00 2001 From: okan Date: Tue, 9 Jul 2013 01:24:49 +0000 Subject: since the root and event window are the same in the case of a button event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen. --- calmwm.h | 4 ++-- group.c | 7 ++----- mousefunc.c | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/calmwm.h b/calmwm.h index d5bf6da..e3543ce 100644 --- a/calmwm.h +++ b/calmwm.h @@ -15,7 +15,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: calmwm.h,v 1.216 2013/07/08 18:39:20 okan Exp $ + * $OpenBSD: calmwm.h,v 1.217 2013/07/09 01:24:49 okan Exp $ */ #ifndef _CALMWM_H_ @@ -360,7 +360,7 @@ void group_autogroup(struct client_ctx *); void group_cycle(struct screen_ctx *, int); void group_hidetoggle(struct screen_ctx *, int); void group_init(struct screen_ctx *); -void group_menu(XButtonEvent *); +void group_menu(struct screen_ctx *); void group_movetogroup(struct client_ctx *, int); void group_only(struct screen_ctx *, int); void group_sticky(struct client_ctx *); diff --git a/group.c b/group.c index 9a66e74..a5a04b2 100644 --- a/group.c +++ b/group.c @@ -16,7 +16,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: group.c,v 1.77 2013/07/08 15:48:16 okan Exp $ + * $OpenBSD: group.c,v 1.78 2013/07/09 01:24:49 okan Exp $ */ #include @@ -309,16 +309,13 @@ group_cycle(struct screen_ctx *sc, int flags) } void -group_menu(XButtonEvent *e) +group_menu(struct screen_ctx *sc) { - struct screen_ctx *sc; struct group_ctx *gc; struct menu *mi; struct menu_q menuq; int i; - sc = screen_fromroot(e->root); - TAILQ_INIT(&menuq); for (i = 0; i < CALMWM_NGROUPS; i++) { diff --git a/mousefunc.c b/mousefunc.c index 366ad9e..12a0f81 100644 --- a/mousefunc.c +++ b/mousefunc.c @@ -16,7 +16,7 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * - * $OpenBSD: mousefunc.c,v 1.55 2013/07/08 18:39:20 okan Exp $ + * $OpenBSD: mousefunc.c,v 1.56 2013/07/09 01:24:49 okan Exp $ */ #include @@ -216,7 +216,7 @@ mousefunc_client_rcyclegroup(struct client_ctx *cc, void *arg) void mousefunc_menu_group(struct client_ctx *cc, void *arg) { - group_menu(arg); + group_menu(cc->sc); } void -- cgit v1.2.3-2-gb3c3