aboutsummaryrefslogtreecommitdiffstats
path: root/xevents.c (follow)
Commit message (Collapse)AuthorAgeLines
* Similar to keypress event, fetch the screen from the event root window in theokan2019-03-08-7/+5
| | | | | buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root.
* extend verbose logging for key/button eventsokan2019-03-08-5/+8
|
* [keypress event] turns out we've been checking the wrong window for a matchingokan2019-03-08-7/+8
| | | | | | | | client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively.
* add parans for readibilityokan2019-03-08-5/+5
|
* Teach client_current() to use a screen to find the current client instead ofokan2019-03-07-6/+6
| | | | | iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
* same thing as screen_find()okan2019-03-06-8/+4
|
* Move the group index (desktop number) check to the only 2 callers that requireokan2019-02-28-3/+7
| | | | checking due to ewmh.
* Rename internal functions to delinate between client remove, delete and xprotookan2019-02-22-4/+4
| | | | | delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
* Allow 'transientfor' clients to inherit group and bwidth either during init orokan2018-11-13-1/+4
| | | | | | via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
* Slightly expand and expose verbose debugging.okan2018-02-04-15/+15
|
* add debugging for x eventsokan2018-02-02-1/+29
|
* As done for buttonrelease, work specific un-cycling and un-highlighting actionsokan2017-12-29-2/+13
| | | | | | | | | into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Additionally, like we do for group membership, grab the keyboard only when required for cycling.
* Merge group_toggle_membership_leave into the buttonrelease event and only dookan2017-12-29-3/+5
| | | | border work for a group/ungroup action.
* add helper function client_show to bring together like actions for unhide/raiseokan2017-12-29-5/+2
|
* Use poll and XNextEvent to replace XNextEvent blocking inside the x11 eventokan2017-12-27-6/+8
| | | | handler.
* drop obsolete commentokan2017-05-09-2/+1
|
* Alter callbacks to take a struct instead of a growing number of arguments;okan2017-05-09-7/+9
| | | | greatly simplifies upcoming work.
* Refactor callbacks to take a void * so as to not try and generalize intookan2016-10-18-20/+32
| | | | | | | | client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. While here, limit some globals, replace defines with appropriate variables and fix some naming.
* Add an argument to the callbacks to pass the xevent context, button orokan2016-10-06-3/+3
| | | | | | | key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road.
* When removing xrandr regions, ensure clients are within the bounds ofokan2016-10-04-1/+2
| | | | | | the screen; adapted from an ancient diff from Sviatoslav Chagaev. Things in this area will likely change, but put this in so it works now and serves as a reminder.
* client_ptrwarp should not deal with unhiding or raising clients (non ptrokan2016-10-03-1/+5
| | | | | requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded.
* During init, query screen for _NET_ACTIVE_WINDOW and set that client asokan2016-09-16-2/+2
| | | | | | | | active; while we already look at what's under the pointer, use this information first, then look under the pointer (saving that round-trip). This restores the active state to a client after restart even if the pointer is not above it (and of course the pointer is not above another client).
* Fix-up a few simple uses of client_current(): check CLIENT_ACTIVE flagokan2016-09-14-4/+7
| | | | instead of relying on curcc.
* Start cleaning up name vs function differences; replace magic numbers.okan2015-11-10-3/+3
|
* Add consistent checks against NULL.okan2015-08-27-4/+4
|
* styleokan2015-07-01-2/+2
|
* Re-implement XClientMessage handling so that we can feed screen_find andokan2015-06-30-39/+43
| | | | | | | | client_find valid resources as needed, relieving the need for screen_find to ungracefully handle invalid root windows. Removes a long standing XXX. Should theoretically allow XClientMessage handling on more than one X screen. Alter callers of screen_find to handle failures.
* Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan2015-01-19-2/+3
| | | | | | and HOST_NAME_MAX+1, respectively. ok doug@
* these have nothing to do with 'sticky', but rather group membership; rename.okan2014-09-27-2/+2
|
* use similiar style for client flagsokan2014-09-15-2/+2
|
* screen_fromroot -> screen_findokan2014-09-07-5/+5
|
* Rework group names: stash the group name inside the group_ctx as opposedokan2014-09-06-2/+2
| | | | | | to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
* Move redundant bits from screen_init (while dealing with existingokan2014-02-03-2/+2
| | | | | | clients) directly into client_init, performing the X roundtrip only once. With the previous change in maprequest, this moves decision making into one place for creating new clients.
* Move redundant window attr fetch from maprequest directly intookan2014-02-02-7/+4
| | | | client_init and perform that X roundtrip only once.
* Move cwm_status around to avoid header fu, and remove extraneous signalokan2014-01-30-2/+1
| | | | header from xevents.c; noticed by Christian Neukirchen.
* Merge keybinding and mousebinding queues into using the same mergedokan2014-01-29-6/+6
| | | | | struct, binding; they were essentially the same accept for what was 'pressed', keysym or button.
* The EWMH spec states that if the cardinal returned is 0xFFFFFFFF (-1)okan2014-01-28-3/+12
| | | | | | then the window should appear on all desktops, which in our case is assigned to group 0. Found to fix stalonetray due to the non-ewmh aware range checking in group_movetogroup(); from Thomas Adam.
* Somewhat streamline event loop/restart/quit handling; most notableokan2014-01-22-11/+7
| | | | | | | | change allows a restart to trigger proper teardown first, even though teardown is not (yet) complete. After some discussion with oga@nicotinebsd.org regarding a more complicated version/idea.
* merge KBFLAG_NEEDCLIENT and MOUSEBIND_CTX_*; brings kbfunc and mousefuncokan2014-01-20-4/+4
| | | | bits even closer.
* use consistent typesokan2014-01-03-3/+3
|
* Accept _NET_CURRENT_DESKTOP ClientMessage; from Thomas Adam, thoughokan2014-01-02-2/+8
| | | | instead of group toggle, group only.
* Accept _NET_WM_DESKTOP clientmessage; from Thomas Adamokan2014-01-02-1/+5
|
* bring mousefunc closer to kbfuncokan2014-01-02-2/+2
|
* stray space and sort while hereokan2013-12-13-5/+4
|
* Add support for XUrgency and matching _NET_WM_STATE_DEMANDS_ATTENTIONokan2013-12-13-1/+2
| | | | | | | ewmh hint; urgencyborder is configurable. The urgency flag will stick, even while on a client in a non-viewable group, until the client receives focus (where the border is reset). Initial diff from Thomas Adam with some changes/enhancements from me.
* ICCCM explicitly states that server time (CurrentTime) should *not* beokan2013-12-12-1/+3
| | | | | | | | | | | used for focus events, but rather the timestamp of the generated event. Track the last event timestamp and send it down for a WM_TAKE_FOCUS ClientMessage. I suspect we should do this for clients that don't announce this Atom as well, though the raciness gets us into a bind. Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@ ok sthen@
* Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotifyokan2013-12-11-1/+4
| | | | events; based off a diff from Thomas Adam.
* Remove extra work and simplify client state handling.okan2013-12-11-3/+2
|
* Since we use IconicState as our hidden state, check for the hidden flagokan2013-12-02-3/+5
| | | | | | | | and unmanage the client if we're not hidden (basically if NormalState) during an UnmapNotify event. Resolves an issue with mplayer going fullscreen while not using NetWM hints; behaviour regression reported by Ido Admon.
* Remove the option to bind a key by keycode with brackets; it neverokan2013-11-27-4/+2
| | | | | | | worked (and no one complained!). While it's fairly easy to fix, users should be using keysym names and not keycodes. Discussed at length months ago with todd@, matthieu@ and Owain.