aboutsummaryrefslogtreecommitdiffstats
path: root/xevents.c (unfollow)
Commit message (Collapse)AuthorLines
2022-01-23Have _NET_ACTIVE_WINDOW warp the pointer only on direct user inputWolfgang Müller-0/+11
This functionally partly reverts commit db0f56a (Do not warp mouse to windows marked active by EWMH, 2022-01-17) which introduced a bug where the pointer would no longer be warped to windows activated by rofi. Since the window switcher internal to cwm calls client_ptr_warp directly this was not noticed immediately. Thankfully the EWMH spec defines a "source indication" [1] in the _NET_ACTIVE_WINDOW request [2]. This field specifies whether the request came from a normal application or a pager and "other clients that represent direct user actions". Window switchers like rofi should honor this field and therefore it is trivial to fix this bug by checking for the correct source indication value. This means that normal windows are now prohibited from warping the pointer under any circumstance, but the user (through specific applications) may still elect to have the window manager honor _NET_ACTIVE_WINDOW this way. [1] https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#sourceindication [2] https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm45682917892304
2022-01-17Do not warp mouse to windows marked active by EWMHWolfgang Müller-1/+0
As discussed a couple of times [1] [2] on the openbsd-* mailing lists, modal dialogs that are marked as active through EWMH will have cwm warp the mouse back to them once it leaves the constraints of the window. For us this is particularly a problem with dialogs created by QT (such as the settings dialog in Quassel). Since no real solution was ever posted on the mailing lists, just disable the warping behaviour for now. This should not have any detrimental impact other than for the dialogs that are "misbehaving" right now. [1] https://marc.info/?l=openbsd-misc&m=155542694605428&w=2 [2] https://marc.info/?l=openbsd-ports&m=155508625010715&w=2
2021-04-27Fix several sign-compare warningsWynn Wolf Arbor-1/+1
2021-04-27Add BSD compatibility functions and headersWynn Wolf Arbor-1/+1
Original file locations in the OpenBSD tree: - lib/libc/stdlib/reallocarray.c - lib/libc/stdlib/strtonum.c - lib/libc/string/strlcat.c - lib/libc/string/strlcpy.c - sys/sys/queue.h
2020-03-26Instead of using _NET_ACTIVE_WINDOW on restart, use the pointer location to ↵okan-2/+2
determine what client to set active. Reduces a round trip for every window.
2020-03-18Unrelated style fixes, consistency changes and sorting, appropriate ↵okan-10/+10
dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
2020-03-18Map ('5') and allow mod5mask (altgr) as a modifier.okan-2/+2
From Artturi Alm (though changed from 'm' to '5')
2019-04-29Handle _NET_WM_NAME changes.tim-2/+3
This fixes the problem where cwm's window menu wouldn't show Firefox's current window title if it contains non-ASCII characters. OK okan@
2019-03-11Check the atom type on propertynotify before iterating.okan-4/+6
2019-03-10use screen_find() for xrandr crtc changesokan-12/+9
2019-03-10Find the managed screen from the parent window for client_current().okan-5/+9
2019-03-08Similar to keypress event, fetch the screen from the event root window in theokan-7/+5
buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root.
2019-03-08extend verbose logging for key/button eventsokan-5/+8
2019-03-08[keypress event] turns out we've been checking the wrong window for a matchingokan-7/+8
client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively.
2019-03-08add parans for readibilityokan-5/+5
2019-03-07Teach client_current() to use a screen to find the current client instead ofokan-6/+6
iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
2019-03-06same thing as screen_find()okan-8/+4
2019-02-28Move the group index (desktop number) check to the only 2 callers that requireokan-3/+7
checking due to ewmh.
2019-02-22Rename internal functions to delinate between client remove, delete and xprotookan-4/+4
delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
2018-11-13Allow 'transientfor' clients to inherit group and bwidth either during init orokan-1/+4
via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
2018-02-04Slightly expand and expose verbose debugging.okan-15/+15
2018-02-02add debugging for x eventsokan-1/+29
2017-12-29As done for buttonrelease, work specific un-cycling and un-highlighting actionsokan-2/+13
into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Additionally, like we do for group membership, grab the keyboard only when required for cycling.
2017-12-29Merge group_toggle_membership_leave into the buttonrelease event and only dookan-3/+5
border work for a group/ungroup action.
2017-12-29add helper function client_show to bring together like actions for unhide/raiseokan-5/+2
2017-12-27Use poll and XNextEvent to replace XNextEvent blocking inside the x11 eventokan-6/+8
handler.
2017-05-09drop obsolete commentokan-2/+1
2017-05-09Alter callbacks to take a struct instead of a growing number of arguments;okan-7/+9
greatly simplifies upcoming work.
2016-10-18Refactor callbacks to take a void * so as to not try and generalize intookan-20/+32
client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. While here, limit some globals, replace defines with appropriate variables and fix some naming.
2016-10-06Add an argument to the callbacks to pass the xevent context, button orokan-3/+3
key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road.
2016-10-04When removing xrandr regions, ensure clients are within the bounds ofokan-1/+2
the screen; adapted from an ancient diff from Sviatoslav Chagaev. Things in this area will likely change, but put this in so it works now and serves as a reminder.
2016-10-03client_ptrwarp should not deal with unhiding or raising clients (non ptrokan-1/+5
requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded.
2016-09-16During init, query screen for _NET_ACTIVE_WINDOW and set that client asokan-2/+2
active; while we already look at what's under the pointer, use this information first, then look under the pointer (saving that round-trip). This restores the active state to a client after restart even if the pointer is not above it (and of course the pointer is not above another client).
2016-09-14Fix-up a few simple uses of client_current(): check CLIENT_ACTIVE flagokan-4/+7
instead of relying on curcc.
2015-11-10Start cleaning up name vs function differences; replace magic numbers.okan-3/+3
2015-08-27Add consistent checks against NULL.okan-4/+4
2015-07-01styleokan-2/+2
2015-06-30Re-implement XClientMessage handling so that we can feed screen_find andokan-39/+43
client_find valid resources as needed, relieving the need for screen_find to ungracefully handle invalid root windows. Removes a long standing XXX. Should theoretically allow XClientMessage handling on more than one X screen. Alter callers of screen_find to handle failures.
2015-01-19Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan-2/+3
and HOST_NAME_MAX+1, respectively. ok doug@
2014-09-27these have nothing to do with 'sticky', but rather group membership; rename.okan-2/+2
2014-09-15use similiar style for client flagsokan-2/+2
2014-09-07screen_fromroot -> screen_findokan-5/+5
2014-09-06Rework group names: stash the group name inside the group_ctx as opposedokan-2/+2
to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
2014-02-03Move redundant bits from screen_init (while dealing with existingokan-2/+2
clients) directly into client_init, performing the X roundtrip only once. With the previous change in maprequest, this moves decision making into one place for creating new clients.
2014-02-02Move redundant window attr fetch from maprequest directly intookan-7/+4
client_init and perform that X roundtrip only once.
2014-01-30Move cwm_status around to avoid header fu, and remove extraneous signalokan-2/+1
header from xevents.c; noticed by Christian Neukirchen.
2014-01-29Merge keybinding and mousebinding queues into using the same mergedokan-6/+6
struct, binding; they were essentially the same accept for what was 'pressed', keysym or button.
2014-01-28The EWMH spec states that if the cardinal returned is 0xFFFFFFFF (-1)okan-3/+12
then the window should appear on all desktops, which in our case is assigned to group 0. Found to fix stalonetray due to the non-ewmh aware range checking in group_movetogroup(); from Thomas Adam.
2014-01-22Somewhat streamline event loop/restart/quit handling; most notableokan-11/+7
change allows a restart to trigger proper teardown first, even though teardown is not (yet) complete. After some discussion with oga@nicotinebsd.org regarding a more complicated version/idea.
2014-01-20merge KBFLAG_NEEDCLIENT and MOUSEBIND_CTX_*; brings kbfunc and mousefuncokan-4/+4
bits even closer.
powered by cgit and git | oriole.systems | how to verify signatures