aboutsummaryrefslogtreecommitdiffstats
path: root/xevents.c (unfollow)
Commit message (Collapse)AuthorLines
2019-03-08Similar to keypress event, fetch the screen from the event root window in theokan-7/+5
buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root.
2019-03-08extend verbose logging for key/button eventsokan-5/+8
2019-03-08[keypress event] turns out we've been checking the wrong window for a matchingokan-7/+8
client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively.
2019-03-08add parans for readibilityokan-5/+5
2019-03-07Teach client_current() to use a screen to find the current client instead ofokan-6/+6
iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
2019-03-06same thing as screen_find()okan-8/+4
2019-02-28Move the group index (desktop number) check to the only 2 callers that requireokan-3/+7
checking due to ewmh.
2019-02-22Rename internal functions to delinate between client remove, delete and xprotookan-4/+4
delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
2018-11-13Allow 'transientfor' clients to inherit group and bwidth either during init orokan-1/+4
via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
2018-02-04Slightly expand and expose verbose debugging.okan-15/+15
2018-02-02add debugging for x eventsokan-1/+29
2017-12-29As done for buttonrelease, work specific un-cycling and un-highlighting actionsokan-2/+13
into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Additionally, like we do for group membership, grab the keyboard only when required for cycling.
2017-12-29Merge group_toggle_membership_leave into the buttonrelease event and only dookan-3/+5
border work for a group/ungroup action.
2017-12-29add helper function client_show to bring together like actions for unhide/raiseokan-5/+2
2017-12-27Use poll and XNextEvent to replace XNextEvent blocking inside the x11 eventokan-6/+8
handler.
2017-05-09drop obsolete commentokan-2/+1
2017-05-09Alter callbacks to take a struct instead of a growing number of arguments;okan-7/+9
greatly simplifies upcoming work.
2016-10-18Refactor callbacks to take a void * so as to not try and generalize intookan-20/+32
client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. While here, limit some globals, replace defines with appropriate variables and fix some naming.
2016-10-06Add an argument to the callbacks to pass the xevent context, button orokan-3/+3
key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road.
2016-10-04When removing xrandr regions, ensure clients are within the bounds ofokan-1/+2
the screen; adapted from an ancient diff from Sviatoslav Chagaev. Things in this area will likely change, but put this in so it works now and serves as a reminder.
2016-10-03client_ptrwarp should not deal with unhiding or raising clients (non ptrokan-1/+5
requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded.
2016-09-16During init, query screen for _NET_ACTIVE_WINDOW and set that client asokan-2/+2
active; while we already look at what's under the pointer, use this information first, then look under the pointer (saving that round-trip). This restores the active state to a client after restart even if the pointer is not above it (and of course the pointer is not above another client).
2016-09-14Fix-up a few simple uses of client_current(): check CLIENT_ACTIVE flagokan-4/+7
instead of relying on curcc.
2015-11-10Start cleaning up name vs function differences; replace magic numbers.okan-3/+3
2015-08-27Add consistent checks against NULL.okan-4/+4
2015-07-01styleokan-2/+2
2015-06-30Re-implement XClientMessage handling so that we can feed screen_find andokan-39/+43
client_find valid resources as needed, relieving the need for screen_find to ungracefully handle invalid root windows. Removes a long standing XXX. Should theoretically allow XClientMessage handling on more than one X screen. Alter callers of screen_find to handle failures.
2015-01-19Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan-2/+3
and HOST_NAME_MAX+1, respectively. ok doug@
2014-09-27these have nothing to do with 'sticky', but rather group membership; rename.okan-2/+2
2014-09-15use similiar style for client flagsokan-2/+2
2014-09-07screen_fromroot -> screen_findokan-5/+5
2014-09-06Rework group names: stash the group name inside the group_ctx as opposedokan-2/+2
to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
2014-02-03Move redundant bits from screen_init (while dealing with existingokan-2/+2
clients) directly into client_init, performing the X roundtrip only once. With the previous change in maprequest, this moves decision making into one place for creating new clients.
2014-02-02Move redundant window attr fetch from maprequest directly intookan-7/+4
client_init and perform that X roundtrip only once.
2014-01-30Move cwm_status around to avoid header fu, and remove extraneous signalokan-2/+1
header from xevents.c; noticed by Christian Neukirchen.
2014-01-29Merge keybinding and mousebinding queues into using the same mergedokan-6/+6
struct, binding; they were essentially the same accept for what was 'pressed', keysym or button.
2014-01-28The EWMH spec states that if the cardinal returned is 0xFFFFFFFF (-1)okan-3/+12
then the window should appear on all desktops, which in our case is assigned to group 0. Found to fix stalonetray due to the non-ewmh aware range checking in group_movetogroup(); from Thomas Adam.
2014-01-22Somewhat streamline event loop/restart/quit handling; most notableokan-11/+7
change allows a restart to trigger proper teardown first, even though teardown is not (yet) complete. After some discussion with oga@nicotinebsd.org regarding a more complicated version/idea.
2014-01-20merge KBFLAG_NEEDCLIENT and MOUSEBIND_CTX_*; brings kbfunc and mousefuncokan-4/+4
bits even closer.
2014-01-03use consistent typesokan-3/+3
2014-01-02Accept _NET_CURRENT_DESKTOP ClientMessage; from Thomas Adam, thoughokan-2/+8
instead of group toggle, group only.
2014-01-02Accept _NET_WM_DESKTOP clientmessage; from Thomas Adamokan-1/+5
2014-01-02bring mousefunc closer to kbfuncokan-2/+2
2013-12-13stray space and sort while hereokan-5/+4
2013-12-13Add support for XUrgency and matching _NET_WM_STATE_DEMANDS_ATTENTIONokan-1/+2
ewmh hint; urgencyborder is configurable. The urgency flag will stick, even while on a client in a non-viewable group, until the client receives focus (where the border is reset). Initial diff from Thomas Adam with some changes/enhancements from me.
2013-12-12ICCCM explicitly states that server time (CurrentTime) should *not* beokan-1/+3
used for focus events, but rather the timestamp of the generated event. Track the last event timestamp and send it down for a WM_TAKE_FOCUS ClientMessage. I suspect we should do this for clients that don't announce this Atom as well, though the raciness gets us into a bind. Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@ ok sthen@
2013-12-11Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotifyokan-1/+4
events; based off a diff from Thomas Adam.
2013-12-11Remove extra work and simplify client state handling.okan-3/+2
2013-12-02Since we use IconicState as our hidden state, check for the hidden flagokan-3/+5
and unmanage the client if we're not hidden (basically if NormalState) during an UnmapNotify event. Resolves an issue with mplayer going fullscreen while not using NetWM hints; behaviour regression reported by Ido Admon.
2013-11-27Remove the option to bind a key by keycode with brackets; it neverokan-4/+2
worked (and no one complained!). While it's fairly easy to fix, users should be using keysym names and not keycodes. Discussed at length months ago with todd@, matthieu@ and Owain.