aboutsummaryrefslogtreecommitdiffstats
path: root/menu.c (follow)
Commit message (Collapse)AuthorAgeLines
* Fix string truncation in menu_drawWynn Wolf Arbor2021-04-27-1/+1
| | | | | The previous size calculation did not account for the prompt characters (0xc2 0xbb and 0xc2 0xab respectively).
* Remove path completion in the exec menuWynn Wolf Arbor2021-04-27-39/+0
| | | | | | | | | | | | | There are a couple of issues I found with this functionality: 1) To my knowledge, it is undocumented and extremely specific. 2) Since this function would only complete a full path (by wrapping it in quotes before passing it on), it is entirely useless when composing a command that has more than one argument. 3) The snprintf call has no check for truncation, possibly leading to the path not being quoted properly.
* Add BSD compatibility functions and headersWynn Wolf Arbor2021-04-27-1/+1
| | | | | | | | | Original file locations in the OpenBSD tree: - lib/libc/stdlib/reallocarray.c - lib/libc/stdlib/strtonum.c - lib/libc/string/strlcat.c - lib/libc/string/strlcpy.c - sys/sys/queue.h
* Unrelated style fixes, consistency changes and sorting, appropriate ↵okan2020-03-18-19/+19
| | | | dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
* Fix regression from r1.107 (lost a return); kettenis@ pointed out the high ↵okan2019-08-24-1/+2
| | | | potential for a use-after-free (true!) where kn@ ran into the regression using an app that actually exercised the XGrabPointer() failure path.
* Separate out the menu window from the client resize/move geom window; in eachokan2019-03-04-51/+33
| | | | case, create and destroy on-demand. Isolate more menu specific code.
* Stop asking for events (NoEventMask) from menu window once done withokan2018-11-14-1/+2
| | | | the menu (we don't destroy it, only unmap).
* Use a variable to keep track of flags for menu_filter().okan2017-12-19-3/+4
|
* clean up after previous (noprompt removal)okan2017-12-12-7/+2
|
* Unconditionally show prompt on menus, regardless of invocation.okan2017-12-11-43/+21
|
* Remove 'noresult' (and simplify) as it does nothing and makes the logic aroundokan2017-04-25-11/+5
| | | | | it needless. History doesn't show what this might have been used for in future iterations.
* stray newlinesokan2016-12-06-3/+1
|
* Add search_print_text(), a default callback for mi->print in menu_filter(). ↵okan2016-12-06-7/+3
| | | | | | While here, normalize the remaining search_print_* argument paramters.
* Tame the number of 'exec' and 'path' search_match wrappers. No functionalokan2016-12-01-2/+2
| | | | | change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits.
* Make it clear these are flags.okan2016-10-24-2/+2
|
* Start simplifying menu code; and in turn, remove a cursor no longerokan2016-10-03-22/+19
| | | | needed.
* Use instinsic X11 functions for key/btn/ptr grab/ungrab/regrab requests;okan2016-09-30-7/+12
| | | | | the one line wrappers provided no value and limited altering calls where needed; additionally, most of them had but one caller.
* Replace mousefunc_sweep_draw() with a generic menu_windraw() using vaokan2016-09-30-1/+33
| | | | | | | lists; use it appropriately for both window dimension and position in the respective mousefunc calls. ok bryent@
* Mechanical change: move screen menu bits to their own struct.okan2016-09-29-16/+16
|
* Inline Xft draw and extents wrappers; too much abstraction.okan2016-09-28-10/+24
|
* Allow ctrl-[ for abort (esc); from Benjamin Scher Purcellokan2016-09-20-1/+4
|
* Enable the use of numpad Enter key on menus; from Henrique N. Lengler.okan2016-08-28-1/+2
| | | | ok beck phessler
* If supplied format to menuq_add() is NULL, fill text with an emptyokan2016-04-28-2/+5
| | | | string; found by Christian Neukirchen.
* Partial revert of replacing screen_area() with region_find(); until aokan2015-11-11-4/+2
| | | | | | fix for a regression is found; this bug has been around for a long time it seems, but this change exposed it. Likely need to track clients in to and out of regions.
* Extend region to include both view and work areas; switch tookan2015-11-09-2/+4
| | | | | | | region_find() which no longer needs to recalculate gap each time a client (or menu) is created or altered. If no RandR, fall back to display dimensions while building regions instead of during execution.
* simplify menu print textokan2015-07-12-16/+9
|
* styleokan2015-07-01-6/+5
|
* style and spacing nitsokan2015-06-30-3/+4
|
* Mechanical change from xinerama to region backed areas.okan2015-06-26-16/+16
|
* clean upokan2015-06-08-17/+14
|
* use the same geometry struct in menus as everywhere elseokan2015-06-05-35/+32
|
* add a flag to indicate a menu list instead of overloading 'prompt'okan2015-06-05-2/+4
|
* redundant check for 'list'okan2015-06-05-2/+2
|
* Reshuffle and slightly simplify menu_complete_path(), removing anokan2015-03-28-10/+6
| | | | allocation, for tab-completion; checked by Alexander Polakov as well.
* Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan2015-01-19-2/+3
| | | | | | and HOST_NAME_MAX+1, respectively. ok doug@
* more style nitsokan2014-09-07-14/+14
|
* style nitokan2014-09-06-3/+3
|
* Take menu's bwidth into account for position/size; reported by Thomas Adam.okan2014-02-01-3/+3
|
* Sprinkle a few more const; from Tiago Cunha.okan2014-01-21-3/+3
|
* Add a function that adds an entry to a menuq, normalizing a common codeokan2014-01-20-1/+18
| | | | path; from Tiago Cunha.
* use consistent typesokan2014-01-03-3/+3
|
* calculate proper menu width/height on the first Expose event; 'jump' (while ↵okan2014-01-02-3/+3
| | | | using gap) noticed by Christian Neukirchen
* replace with memsetokan2013-12-17-2/+2
|
* Teach screen_find_xinerama() to apply gap only when told to do so;okan2013-12-13-2/+2
| | | | adjust callers. Needed for an upcoming feature.
* When we receive a NotionNotify event, there's no need to (incorrectlyokan2013-12-02-4/+1
| | | | might I add) redraw the top menu selection.
* Always highlight the first menu item (helpful to see selected items whenokan2013-12-02-5/+3
| | | | | not using a mouse and therefore not generating Expose/MotionNotify events); from Thomas Adam.
* move Cursors into conf.okan2013-06-17-4/+5
|
* stray whitespaceokan2013-05-20-2/+2
|
* - configure menuwin with the screen, then create the xft drawable usingokan2013-05-20-13/+4
| | | | | the menu window since that's the only place on which we draw - elminate the need to change the drawable on every font draw
* no reason to pass around *sc when it's already in menu_ctx.okan2013-05-20-34/+32
|