aboutsummaryrefslogtreecommitdiffstats
path: root/menu.c (unfollow)
Commit message (Collapse)AuthorLines
2021-04-27Fix string truncation in menu_drawWynn Wolf Arbor-1/+1
The previous size calculation did not account for the prompt characters (0xc2 0xbb and 0xc2 0xab respectively).
2021-04-27Remove path completion in the exec menuWynn Wolf Arbor-39/+0
There are a couple of issues I found with this functionality: 1) To my knowledge, it is undocumented and extremely specific. 2) Since this function would only complete a full path (by wrapping it in quotes before passing it on), it is entirely useless when composing a command that has more than one argument. 3) The snprintf call has no check for truncation, possibly leading to the path not being quoted properly.
2021-04-27Add BSD compatibility functions and headersWynn Wolf Arbor-1/+1
Original file locations in the OpenBSD tree: - lib/libc/stdlib/reallocarray.c - lib/libc/stdlib/strtonum.c - lib/libc/string/strlcat.c - lib/libc/string/strlcpy.c - sys/sys/queue.h
2020-03-18Unrelated style fixes, consistency changes and sorting, appropriate ↵okan-19/+19
dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
2019-08-24Fix regression from r1.107 (lost a return); kettenis@ pointed out the high ↵okan-1/+2
potential for a use-after-free (true!) where kn@ ran into the regression using an app that actually exercised the XGrabPointer() failure path.
2019-03-04Separate out the menu window from the client resize/move geom window; in eachokan-51/+33
case, create and destroy on-demand. Isolate more menu specific code.
2018-11-14Stop asking for events (NoEventMask) from menu window once done withokan-1/+2
the menu (we don't destroy it, only unmap).
2017-12-19Use a variable to keep track of flags for menu_filter().okan-3/+4
2017-12-12clean up after previous (noprompt removal)okan-7/+2
2017-12-11Unconditionally show prompt on menus, regardless of invocation.okan-43/+21
2017-04-25Remove 'noresult' (and simplify) as it does nothing and makes the logic aroundokan-11/+5
it needless. History doesn't show what this might have been used for in future iterations.
2016-12-06stray newlinesokan-3/+1
2016-12-06Add search_print_text(), a default callback for mi->print in menu_filter(). ↵okan-7/+3
While here, normalize the remaining search_print_* argument paramters.
2016-12-01Tame the number of 'exec' and 'path' search_match wrappers. No functionalokan-2/+2
change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits.
2016-10-24Make it clear these are flags.okan-2/+2
2016-10-03Start simplifying menu code; and in turn, remove a cursor no longerokan-22/+19
needed.
2016-09-30Use instinsic X11 functions for key/btn/ptr grab/ungrab/regrab requests;okan-7/+12
the one line wrappers provided no value and limited altering calls where needed; additionally, most of them had but one caller.
2016-09-30Replace mousefunc_sweep_draw() with a generic menu_windraw() using vaokan-1/+33
lists; use it appropriately for both window dimension and position in the respective mousefunc calls. ok bryent@
2016-09-29Mechanical change: move screen menu bits to their own struct.okan-16/+16
2016-09-28Inline Xft draw and extents wrappers; too much abstraction.okan-10/+24
2016-09-20Allow ctrl-[ for abort (esc); from Benjamin Scher Purcellokan-1/+4
2016-08-28Enable the use of numpad Enter key on menus; from Henrique N. Lengler.okan-1/+2
ok beck phessler
2016-04-28If supplied format to menuq_add() is NULL, fill text with an emptyokan-2/+5
string; found by Christian Neukirchen.
2015-11-11Partial revert of replacing screen_area() with region_find(); until aokan-4/+2
fix for a regression is found; this bug has been around for a long time it seems, but this change exposed it. Likely need to track clients in to and out of regions.
2015-11-09Extend region to include both view and work areas; switch tookan-2/+4
region_find() which no longer needs to recalculate gap each time a client (or menu) is created or altered. If no RandR, fall back to display dimensions while building regions instead of during execution.
2015-07-12simplify menu print textokan-16/+9
2015-07-01styleokan-6/+5
2015-06-30style and spacing nitsokan-3/+4
2015-06-26Mechanical change from xinerama to region backed areas.okan-16/+16
2015-06-08clean upokan-17/+14
2015-06-05use the same geometry struct in menus as everywhere elseokan-35/+32
2015-06-05add a flag to indicate a menu list instead of overloading 'prompt'okan-2/+4
2015-06-05redundant check for 'list'okan-2/+2
2015-03-28Reshuffle and slightly simplify menu_complete_path(), removing anokan-10/+6
allocation, for tab-completion; checked by Alexander Polakov as well.
2015-01-19Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan-2/+3
and HOST_NAME_MAX+1, respectively. ok doug@
2014-09-07more style nitsokan-14/+14
2014-09-06style nitokan-3/+3
2014-02-01Take menu's bwidth into account for position/size; reported by Thomas Adam.okan-3/+3
2014-01-21Sprinkle a few more const; from Tiago Cunha.okan-3/+3
2014-01-20Add a function that adds an entry to a menuq, normalizing a common codeokan-1/+18
path; from Tiago Cunha.
2014-01-03use consistent typesokan-3/+3
2014-01-02calculate proper menu width/height on the first Expose event; 'jump' (while ↵okan-3/+3
using gap) noticed by Christian Neukirchen
2013-12-17replace with memsetokan-2/+2
2013-12-13Teach screen_find_xinerama() to apply gap only when told to do so;okan-2/+2
adjust callers. Needed for an upcoming feature.
2013-12-02When we receive a NotionNotify event, there's no need to (incorrectlyokan-4/+1
might I add) redraw the top menu selection.
2013-12-02Always highlight the first menu item (helpful to see selected items whenokan-5/+3
not using a mouse and therefore not generating Expose/MotionNotify events); from Thomas Adam.
2013-06-17move Cursors into conf.okan-4/+5
2013-05-20stray whitespaceokan-2/+2
2013-05-20- configure menuwin with the screen, then create the xft drawable usingokan-13/+4
the menu window since that's the only place on which we draw - elminate the need to change the drawable on every font draw
2013-05-20no reason to pass around *sc when it's already in menu_ctx.okan-34/+32