aboutsummaryrefslogtreecommitdiffstats
path: root/kbfunc.c (follow)
Commit message (Collapse)AuthorAgeLines
* Warp pointer to last active window if there is no active clientWalter Alejandro Iglesias2021-04-27-0/+10
| | | | | | | | | | If a client is killed and the cursor lands in the root window, no client is focused. Attempting to cycle back to the last focused client will instead focus the previous-to-last. Add specific checks that make sure the cursor is positioned where the user expects it to be. This patch was taken from a bug report on openbsd-misc [1]. [1] https://marc.info/?l=openbsd-tech&m=155931484124288&w=2
* Return the window position overlay menu to its old formatWynn Wolf Arbor2021-04-27-2/+2
|
* Fix several sign-compare warningsWynn Wolf Arbor2021-04-27-1/+3
|
* Calculate colors using the client's visual and colormapWynn Wolf Arbor2021-04-27-2/+2
| | | | | | | | | | | | | | | As cwm was using the screen's default visual and colormap to draw all client borders, borders for windows that had a depth of 32 bits were not rendered correctly. The same happened with text in the popup menus which were recently changed to be drawn in the context of the client. This commit introduces a Visual reference for each client, and allocates all potential colors for a client's specific visual and colormap in the client_ctx struct. These colors are then used to draw client borders and popup menus. Additionally, since we touch the drawing code anyway, borders are reintroduced to the popup menus for better contrast.
* Remove wm menuWynn Wolf Arbor2021-04-27-27/+0
| | | | | | | | Whilst arguably useful for certain people, or in rare cases, this functionality is not needed in the general case. This will also remove a memory leak where fallback was not properly freed.
* Remove ssh menuWynn Wolf Arbor2021-04-27-66/+0
| | | | | | There is no point in keeping this functionality. Saving a few key strokes is not worth the added complexity of the window manager parsing the known_hosts file.
* Add BSD compatibility functions and headersWynn Wolf Arbor2021-04-27-1/+1
| | | | | | | | | Original file locations in the OpenBSD tree: - lib/libc/stdlib/reallocarray.c - lib/libc/stdlib/strtonum.c - lib/libc/string/strlcat.c - lib/libc/string/strlcpy.c - sys/sys/queue.h
* Simplify conditional construct.tim2020-03-26-6/+3
| | | | OK okan@
* No need to lookup current client early; move to right before it is needed.okan2020-03-26-4/+2
|
* Unrelated style fixes, consistency changes and sorting, appropriate ↵okan2020-03-18-14/+56
| | | | dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
* Ensure the pointer stays within client bounds after a window 'snap' (to edge).okan2020-03-18-1/+2
| | | | reported by Stefan Hagen.
* Because cwm warps the pointer during a client move (to stay within the ↵okan2019-08-24-1/+3
| | | | | | client), there's a window of time where an expose or enternotify event will get generated for a lower client; use a hammer and drain events after keyboard move/resize, until such a time that cwm doesn't warp the pointer. Behavior noticed by kn. ok kn@
* Teach client_current() to use a screen to find the current client instead ofokan2019-03-07-2/+2
| | | | | iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
* shuffle deck chairs: rename group actions to match intent for clarityokan2019-03-07-10/+10
|
* Separate out the menu window from the client resize/move geom window; in eachokan2019-03-04-11/+10
| | | | case, create and destroy on-demand. Isolate more menu specific code.
* Add 'group-close-[n]' action to close all windows within specified group.okan2019-02-25-1/+7
| | | | heavily based on a diff from Nam Nguyen.
* Rename internal functions to delinate between client remove, delete and xprotookan2019-02-22-3/+3
| | | | | delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
* fix missing includesokan2019-02-13-1/+2
|
* Convert menu-exec-wm from an abritrary exec menu, into a config-based menu fromokan2017-12-29-29/+31
| | | | | | | | which one may configure (wm <name> <path_and_args>) (and choose) specific window managers to replace the running one. 'wm cwm cwm' is included by default. No objections and seems sensible to sthen.
* As done for buttonrelease, work specific un-cycling and un-highlighting actionsokan2017-12-29-3/+10
| | | | | | | | | into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Additionally, like we do for group membership, grab the keyboard only when required for cycling.
* Merge group_toggle_membership_leave into the buttonrelease event and only dookan2017-12-29-2/+2
| | | | border work for a group/ungroup action.
* add helper function client_show to bring together like actions for unhide/raiseokan2017-12-29-5/+2
|
* Use a variable to keep track of flags for menu_filter().okan2017-12-19-14/+22
|
* Unconditionally show prompt on menus, regardless of invocation.okan2017-12-11-6/+4
|
* Original idea from Dimitris Papastamos to move windows to corners a while ago;okan2017-12-07-1/+37
| | | | | | | | | re-proposed by Julien Steinhauser with an updated diff. Apparently this was in the original calmnwm. However, expand the original idea and let clients 'snap' to edges instead, neatly allowing key bindings that snap to adjacent edges (i.e. corners) as well. No default bindings assigned.
* give command and group menus their own match callbacksokan2017-12-07-6/+5
|
* spacingokan2017-12-07-4/+3
|
* Revert r1.109 (Switch to XWindowEvent() pulling out events that match the maskokan2017-11-30-3/+3
| | | | | | | *and* window.) of mousefunc.c. When a client destroys itself while we are moving or resizing it, XWindowEvent() blocks. Found the hard way by Anton Lazarov, and Lea°hNeukirchen found the right bit to revert - thanks! Reverting since the reason to switch from XMaskEvent was unclear.
* remove extra parenthesesokan2017-07-14-3/+3
|
* Pull over the remaining re-implemented window move/resize functions and createokan2017-07-14-3/+140
| | | | | a wrapper so that the key and mouse based move/resize callbacks can be unified. This has already been done with other window operations and menus.
* rename one function, matching others, to help upcoming changeokan2017-07-12-2/+2
|
* Replace fgetln(3) with POSIX getline(3); inspired by brynet and Ingo.okan2017-07-10-12/+11
| | | | feedback and ok brynet@
* Alter callbacks to take a struct instead of a growing number of arguments;okan2017-05-09-51/+50
| | | | greatly simplifies upcoming work.
* Clean up, unify and accurately calculate edge distance with client move/resizeokan2017-05-01-44/+22
| | | | | | actions, so as to not lose windows off the edge. inspired by diffs (and feedback) from Vadim Vygonets.
* Ensure client stays inbound on key-based resize; based on logic existing inokan2017-01-05-1/+5
| | | | key-based client move; from Vadim Vygonets.
* Add search_print_text(), a default callback for mi->print in menu_filter(). ↵okan2016-12-06-4/+4
| | | | | | While here, normalize the remaining search_print_* argument paramters.
* Consistent use of menuq_add for ssh menu.okan2016-12-06-2/+2
|
* Tame the number of 'exec' and 'path' search_match wrappers. No functionalokan2016-12-01-2/+2
| | | | | change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits.
* Switch ssh menu to search_match_text; like group/window/cmd menus, use only aokan2016-12-01-2/+2
| | | | substring match. The previous matching is only intended for the exec menus.
* Change 'menu-window' to display all windows; then add 'menu-window-hidden' forokan2016-12-01-2/+3
| | | | | | | | the previous behaviour of 'menu-window'. 'menu-window' becomes the default binding; use 'bind-mouse "1" menu-window-hidden' to restore old behaviour for those who prefer. OK sthen@ (long long time ago on a different version)
* Use an additional check with lstat(2) when d_type is unknown.okan2016-11-15-4/+11
| | | | from James McDonald via portable.
* revert previous; upcoming changes will hopefully deal with these moreokan2016-11-15-23/+1
| | | | naturally.
* Add a wrapper based upon xevent handlers around client move/resize for key andokan2016-11-15-1/+23
| | | | mouse bindings.
* Make it clear these are flags.okan2016-10-24-7/+7
|
* Sprinkle __func__ in appropriate error messages.okan2016-10-24-4/+4
|
* Refactor callbacks to take a void * so as to not try and generalize intookan2016-10-18-167/+171
| | | | | | | | client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. While here, limit some globals, replace defines with appropriate variables and fix some naming.
* Rename 2 kbfunc to match closer to what they dookan2016-10-06-3/+3
|
* Add an argument to the callbacks to pass the xevent context, button orokan2016-10-06-36/+36
| | | | | | | key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road.
* For both kb and mouse move, it is possible to grab a client and move itokan2016-10-03-2/+14
| | | | | completely off the screen/region; instead, if the pointer is outside of the client bounds, warp the pointer to the closest edge before moving.
* client_ptrwarp should not deal with unhiding or raising clients (non ptrokan2016-10-03-1/+3
| | | | | requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded.