aboutsummaryrefslogtreecommitdiffstats
path: root/group.c (follow)
Commit message (Collapse)AuthorAgeLines
* gc->hidden has never consistently kept track of a group's state;okan2014-08-24-30/+19
| | | | | | | | | | group_show() and group_hide() are not the only ways a group can change state - if all clients in a group are either hidden or unhidden, then that group's state should change, as well as the various EWMH ways. Instead of trying to keep track in a wide variety of places, simply query the clients in a group before needing to take action based on the group's state. Solves long standing confusion of when a group is hidden or not.
* Fix nogroup regression, where nogroup became an actual group - theokan2014-08-22-13/+12
| | | | | | | | | | symantics between cwm groups and ewmh got in the way. Ensure a client that wants to be in nogroup stays in nogroup (thus stays in view), even when (re)reading NET_WM_DESKTOP. Paritially reverts patchset 644 (2014-02-07 13:09 PST) which deals with a NULL cc->group. All to be revisited when NET_WM_STATE_STICKY hits cwm. Reported by many; testing and ok phessler.
* Purely mechanical; unify 'num', 'no' and 'shortcut'.okan2014-08-20-20/+20
|
* Split off group window restacking.okan2014-08-20-5/+16
|
* fix a misleading comment and function nameokan2014-08-20-6/+6
|
* Pull highstack from group_ctx (and useless calculations of); in the oneokan2014-08-19-17/+10
| | | | | place that we use highstack, replace that usage with a local variable (for now until stacking is done properly).
* Get rid of nhidden in group_ctx; it actually never reported correctlyokan2014-08-18-8/+6
| | | | | | | since nhidden wasn't incremented nor decremeted in all the right places, thus confusing matters. We don't need to carry a count around, so just use a local variable in the one place we need one to supply XRestackWindows().
* Make sure we cycle through existing client's group membership and setokan2014-02-08-1/+10
| | | | | the hidden state on the group; important to know group hidden state after a re-exec or restart of cwm (as easily seen in group menu).
* Replace a few hand rolled loops with like tailq loops.okan2014-02-08-17/+13
|
* If _NET_WM_DESKTOP is set to -1 during client creation, place the client intookan2014-02-07-29/+13
| | | | | | | | | | | | group 0 (nogroup); solves problem initially discovered by oga@nicotinebsd with tint2. A clientmessage *after* client creation already handles this case. Go further and assign every client to a group; in non-sticky mode, group 0 (nogroup) and sticky mode, the active group. In both cases, autogroup will override the group assignment. Removing a group from a client always places the client back into group 0 (nogroup). Autogroup can also assign a client to group 0 (nogroup) to keep a client always visible (unless of course one opts to hide all clients).
* correct arguments and drop the cast.okan2014-01-24-2/+2
| | | | sanity check by oga@nicotinebsd
* Add a function that adds an entry to a menuq, normalizing a common codeokan2014-01-20-10/+3
| | | | path; from Tiago Cunha.
* Stash Class and WM Hints in client_ctxokan2013-12-11-4/+4
|
* a few err->errx since we don't have error messages here; from Tiago Cunhaokan2013-10-17-4/+4
|
* unify type; no changeokan2013-10-03-2/+2
|
* simplify atom handling; allows us to limit to one round-trip to serverokan2013-07-15-4/+4
| | | | for gathering Atoms.
* since the root and event window are the same in the case of a buttonokan2013-07-09-5/+2
| | | | | | | event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen.
* replace a few (x)malloc with (x)calloc to prevent potential integerokan2013-07-08-3/+3
| | | | overflows; from Tiago Cunha
* remove group in client_delete directly.okan2013-05-06-12/+1
|
* type fixokan2013-04-30-3/+2
|
* add conf_ignore and move group_make_autogroup to conf_autogroup to match.okan2013-04-17-22/+1
|
* reverse logic to make it like the othersokan2013-04-08-9/+5
|
* consistencyokan2013-04-08-1/+2
|
* zap stray whitespaceokan2013-04-05-2/+2
|
* put back r1.68 which allows an empty group to be sticky; behaviorokan2013-01-13-2/+6
| | | | | | change noticed by Thomas Pfaff and diagnosis why we need to group_setactive in this case by Alexander Polakov. replace XXX with a useful comment.
* set the initial group to '1', missed by recent off-by-one groupokan2013-01-10-2/+2
| | | | | | numbering re-work; discovered the hard way by sthen@. ok sthen@
* after we toggle a group hidden, it makes no sense to set it as activeokan2013-01-01-6/+2
| | | | | | | | (in sticky or non-stick mode), regardless of existing clients assigned to that group; oga marked this bit XXX in -r1.34 for it didn't seem make sense then either. pulled from a diff from from Alexander Polakov.
* make num of groups no longer off-by-one; from Alexander Polakovokan2013-01-01-6/+6
| | | | | | note that a re-exec of cwm will not rewrite the group number atom of *existing* clients, so they will remain off-by-one until each client has its atom updated, or of course a restart of X.
* replace client highlight with a client flagokan2012-12-17-7/+5
|
* create and use menuq_clear() helper; from Tiago Cunhaokan2012-12-17-5/+2
|
* specific last match for autogroup; few iterations with Kent Spillner.okan2012-11-29-7/+9
|
* sortokan2012-11-09-2/+2
|
* fix some warnings; inspired by a diff from Thordur Bjornsson.okan2012-11-08-3/+3
|
* get rid of the xfree() wrapper around free(); from Tiago Cunha.okan2012-11-07-4/+4
|
* replace with xu_getprop wrapper used everywhere else.okan2012-09-09-13/+7
|
* remove a redundant assignment and another one up.okan2012-07-08-3/+2
|
* re-implement atom handing; makes for a normalized and more consistentokan2012-07-03-39/+18
| | | | separation between cwm and ewmh. seen by a few.
* get rid of more stray lines/spacesokan2012-05-16-3/+3
|
* fix commentokan2012-05-16-3/+4
|
* check if we're in the group already, else multiple calls tookan2011-12-29-2/+4
| | | | | | | | | | group_movetogroup() on one client will still increment nhidden if the group is hidden. found the hard way by Thomas Jeunet and fix from Alexander Polakov - thanks to both! ok oga@
* use xfree instead of free since strings is allocated with xmalloc; fromokan2011-10-12-2/+2
| | | | | | dhill ok oga@
* move client to group (movetogroup) and hide client only if group isokan2011-09-19-2/+6
| | | | | | already hidden (suggested behavior from Alexander Polakov). ok sthen oga
* repair groupcycle (broke after cycle-in-group support added more flags);okan2011-09-13-6/+6
| | | | | | found by and fix from Thomas Pfaff. ok oga@
* We are inconsistent when it comes to function returns, so just go allokan2011-07-25-4/+4
| | | | | | the way with the cwm specific parts. ok oga@
* tag and comment cleanup; ok oga@okan2011-05-11-1/+1
|
* we lose track of highstack somewhere, so recompute it before we need it.tedu2011-02-13-1/+6
| | | | fixes a crash reported by christian neukirchen. ok okan
* spacing nitsokan2010-09-25-1/+2
|
* more clear variable name so than name/class shouldn't be confused again.okan2010-09-25-5/+5
| | | | ok oga@
* revert -r1.45 of group.c (log was: fix window name and class to matchokan2010-07-30-3/+4
| | | | | | | | | | | | cwmrc(5)). instead, fix cwmrc(5) to match the old behavior which also happens to match the example config, of which many have based their configs; this also nicely matches the output of xprop(1). clean-up of variable names as a separate commit. suggested by sthen (and something we should have done initially). discussed with and ok oga@
* fix window name and class to match cwmrc(5); from Holger Mikolon - thanks!okan2010-06-28-4/+3
| | | | ok oga@
powered by cgit and git | oriole.systems | how to verify signatures