aboutsummaryrefslogtreecommitdiffstats
path: root/group.c (unfollow)
Commit message (Collapse)AuthorLines
2015-08-25Allowing sending a valid 'nogroup' (0) group_ctx to group_assign()okan-6/+7
(since we init all groups), though assigning the client's group to NULL for 'sticky'; use this simplification in a few places (others to follow).
2015-08-25Split out sticky mode checks and the restoring of a client's group andokan-33/+46
_NET_WM_DESKTOP from the config-based auto-grouping; no (intentional) behavior changes. Needed for further work in cleaning up this area.
2015-08-23Move CLIENT_STICKY logic from client hide/unhide to group hide/unhide;okan-5/+9
rationale being that clients should be able to hide/unhide independently of group switching.
2015-08-21Bring group and client cycle closer together.okan-21/+35
2015-06-28replace assert usageokan-4/+3
2015-03-28Introduce a xreallocarray and convert a few xcalloc instances that dookan-2/+2
not require zero'ing.
2015-01-19Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan-2/+3
and HOST_NAME_MAX+1, respectively. ok doug@
2014-10-08make group_init work like other *_init'sokan-15/+14
2014-09-27these have nothing to do with 'sticky', but rather group membership; rename.okan-6/+3
2014-09-27Pass just the group to group_setactive instead of the screen and anokan-13/+9
index which then needed to be found in a queue.
2014-09-23Update _NET_CURRENT_DESKTOP with the screen's group_active->num.okan-4/+4
2014-09-23Move stuff that doesn't belong in group_init; while here, explicitlyokan-12/+3
initialize hideall and cycling.
2014-09-17Use a similarly named check as sticky for hidden check in a group.okan-10/+6
2014-09-17Introduce a check to see if a group holds only 'sticky' clients and useokan-2/+15
this check to decide if a group is virtually empty. Rationale: if a group contains *only* 'sticky' clients, it should be skipped while cycling through groups. Apply similar logic to the group menu. Based on an idea from phessler@, who also tested another version.
2014-09-08name the group client queue appropriately, like other queuesokan-11/+11
2014-09-08Now that a group knows its screen, only pass down the group_ctx.okan-17/+17
2014-09-07Add screen_ctx to group_ctx, and populate on init.okan-1/+2
2014-09-07Get rid of a redundant array of groups per screen; we already have aokan-9/+23
link to the group queue for each screen.
2014-09-06Rework group names: stash the group name inside the group_ctx as opposedokan-53/+3
to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
2014-09-01Merge group_menu into mousefunc_menu_group.okan-37/+4
2014-08-25Since the flatting out of sc->group_names is only for settingokan-25/+3
NET_DESKTOP_NAMES, merge the helper into xu_ewmh_net_desktop_names, where we actually set the property.
2014-08-25Implement _NET_WM_STATE_STICKY, bound to CM-s by default; allows anyokan-1/+3
client to 'stick' to all desktops (ewmh speak) or groups - this currently has the same affect as setting a client's group to 'nogroup', with the exception that the client can also be in a group, so when un-sticking, the client will go back to its original group/desktop.
2014-08-24gc->hidden has never consistently kept track of a group's state;okan-30/+19
group_show() and group_hide() are not the only ways a group can change state - if all clients in a group are either hidden or unhidden, then that group's state should change, as well as the various EWMH ways. Instead of trying to keep track in a wide variety of places, simply query the clients in a group before needing to take action based on the group's state. Solves long standing confusion of when a group is hidden or not.
2014-08-22Fix nogroup regression, where nogroup became an actual group - theokan-13/+12
symantics between cwm groups and ewmh got in the way. Ensure a client that wants to be in nogroup stays in nogroup (thus stays in view), even when (re)reading NET_WM_DESKTOP. Paritially reverts patchset 644 (2014-02-07 13:09 PST) which deals with a NULL cc->group. All to be revisited when NET_WM_STATE_STICKY hits cwm. Reported by many; testing and ok phessler.
2014-08-20Purely mechanical; unify 'num', 'no' and 'shortcut'.okan-20/+20
2014-08-20Split off group window restacking.okan-5/+16
2014-08-20fix a misleading comment and function nameokan-6/+6
2014-08-19Pull highstack from group_ctx (and useless calculations of); in the oneokan-17/+10
place that we use highstack, replace that usage with a local variable (for now until stacking is done properly).
2014-08-18Get rid of nhidden in group_ctx; it actually never reported correctlyokan-8/+6
since nhidden wasn't incremented nor decremeted in all the right places, thus confusing matters. We don't need to carry a count around, so just use a local variable in the one place we need one to supply XRestackWindows().
2014-02-08Make sure we cycle through existing client's group membership and setokan-1/+10
the hidden state on the group; important to know group hidden state after a re-exec or restart of cwm (as easily seen in group menu).
2014-02-08Replace a few hand rolled loops with like tailq loops.okan-17/+13
2014-02-07If _NET_WM_DESKTOP is set to -1 during client creation, place the client intookan-29/+13
group 0 (nogroup); solves problem initially discovered by oga@nicotinebsd with tint2. A clientmessage *after* client creation already handles this case. Go further and assign every client to a group; in non-sticky mode, group 0 (nogroup) and sticky mode, the active group. In both cases, autogroup will override the group assignment. Removing a group from a client always places the client back into group 0 (nogroup). Autogroup can also assign a client to group 0 (nogroup) to keep a client always visible (unless of course one opts to hide all clients).
2014-01-24correct arguments and drop the cast.okan-2/+2
sanity check by oga@nicotinebsd
2014-01-20Add a function that adds an entry to a menuq, normalizing a common codeokan-10/+3
path; from Tiago Cunha.
2013-12-11Stash Class and WM Hints in client_ctxokan-4/+4
2013-10-17a few err->errx since we don't have error messages here; from Tiago Cunhaokan-4/+4
2013-10-03unify type; no changeokan-2/+2
2013-07-15simplify atom handling; allows us to limit to one round-trip to serverokan-4/+4
for gathering Atoms.
2013-07-09since the root and event window are the same in the case of a buttonokan-5/+2
event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen.
2013-07-08replace a few (x)malloc with (x)calloc to prevent potential integerokan-3/+3
overflows; from Tiago Cunha
2013-05-06remove group in client_delete directly.okan-12/+1
2013-04-30type fixokan-3/+2
2013-04-17add conf_ignore and move group_make_autogroup to conf_autogroup to match.okan-22/+1
2013-04-08reverse logic to make it like the othersokan-9/+5
2013-04-08consistencyokan-1/+2
2013-04-05zap stray whitespaceokan-2/+2
2013-01-13put back r1.68 which allows an empty group to be sticky; behaviorokan-2/+6
change noticed by Thomas Pfaff and diagnosis why we need to group_setactive in this case by Alexander Polakov. replace XXX with a useful comment.
2013-01-10set the initial group to '1', missed by recent off-by-one groupokan-2/+2
numbering re-work; discovered the hard way by sthen@. ok sthen@
2013-01-01after we toggle a group hidden, it makes no sense to set it as activeokan-6/+2
(in sticky or non-stick mode), regardless of existing clients assigned to that group; oga marked this bit XXX in -r1.34 for it didn't seem make sense then either. pulled from a diff from from Alexander Polakov.
2013-01-01make num of groups no longer off-by-one; from Alexander Polakovokan-6/+6
note that a re-exec of cwm will not rewrite the group number atom of *existing* clients, so they will remain off-by-one until each client has its atom updated, or of course a restart of X.