aboutsummaryrefslogtreecommitdiffstats
path: root/client.c (follow)
Commit message (Collapse)AuthorAgeLines
* instead of checking for flags in the client context, then removing them.oga2009-08-24-3/+2
| | | | | | | | | | | e.g.: if (flags & flags_we_care_about) flags &= ~(flags_we_care_about); just whack the flags unconditionally, it's simpler. okan@ agrees.
* static local functions and data; almost identical diff from Thomas Pfaffokan2009-06-26-8/+14
| | | | ok oga@
* tidy up startup/init routinesokan2009-06-23-2/+2
| | | | ok oga@
* compact a bit by condensing a few if-else's; from Thomas Pfaffokan2009-06-20-11/+3
| | | | "go on then" oga@
* unroll XCALLOC/XMALLOC macros; since we use xcalloc/xmalloc all over theokan2009-06-20-3/+3
| | | | | | place anyway, this makes things a bit more consistent; from Thomas Pfaff ok oga@
* spacingokan2009-06-20-3/+1
|
* re-factor parts of mouse move/resize bit to shrink and make moreokan2009-06-17-6/+1
| | | | | | readable; no behavior change ok oga@
* re-order a bit for readability.okan2009-05-30-11/+8
| | | | "if it makes you happy" oga@
* nuke the leading underscore notation for local static functions - thereokan2009-05-18-4/+4
| | | | | | are far better ways to know. "go for it" oga@
* a long time coming - re-work the way we deal with colors: since we'reokan2009-05-17-9/+9
| | | | | | | | using Xft(3), use it to select the font color as well instead of trying to build one; properly allocate and free colors at-will, e.g. we now have configurable colors. feedback and ok's todd@ and oga@
* redraw the border when unhiding a client window. fixes the situation wheresthen2009-05-17-1/+2
| | | | | | | | you change to a different group and the mouse isn't over a window; previously the border of the previously active window was highlighted but it didn't actually have focus. reads ok to oga@.
* passing a null pointer to free() is valid; sprinkle a few free->xfree.okan2009-01-23-3/+2
| | | | ok oga@
* now that pwin is gone gone gone, we no longer have to do the bwidthokan2009-01-22-30/+27
| | | | | | | dance; xevents now able to deal with a border being set (which fixes those annoying movie-watching apps). ok todd@, oga@
* Cache all of the X atoms we use at startup.oga2009-01-22-20/+8
| | | | | | | | Do this instead of querying for them every time we use them. This removes an XXX that has been in there since time began. This will become more important as we move towards supporting netwm. ok todd@, okan@.
* Finally fix the really annoying race where if you rapidly switch groups severaloga2009-01-17-5/+2
| | | | | | | | | | | | | | | | | | | | | | times you'd end up losing clients (thinking they had gone away). From the ICCCM (which should not be read without a stiff drink in hand, I made this mistake so you don't have to): to request a window to be withdrawn one should send a synthetic UnmapRequest event when iconified. To request iconification one should just unmap the window. The ICCM further recommends that the synthetic event should just be taken as a cue to withdraw, to deal with legacy clients. Taking a hint from this, rework xev_handle_unmaprequest to correctly detect these situations. A Withdrawn window may come back anywhere, even as a subwindow of something else, so the correct way to handle this state is to forget it ever existed. While i'm here, kill a dumb attempt to notice this in client_delete, and nuke the very unnecessary arguments. Todd confirmed this fixes the `race'. ok todd@, ok ok okan@
* remove pwin, bringing us to one client, one window. we no longer haveokan2009-01-16-156/+34
| | | | | | | | | | | | to push attributes around, so things get a lot simplier, while fixing a few issues in the meantime; original suggestion by Edd Barrett many many moons ago. annoying window placement and race, found in c2k8 by todd, fix by oga! lots of feedback from todd and oga - thanks! "commit that bad boy" oga@
* - add missing prototypes.okan2009-01-15-33/+12
| | | | | | | | | - properly name, place and static private functions. - move function which finds the xinerama screen for a coordinate to a more appropriate place while altering its semantics to match others. - tiny bit of style. ok oga@
* Xinerama and XRandR dual head support for cwm(1). Now we detect the xrandroga2008-09-29-28/+105
| | | | | | | | | | | reconfiguration events and change our sizes depending on that. We also detect the xinerama screens for maximize, vertmaximize and initial window placement. This could be improved by automatically resizing maximized windows when the screen resolution changes and by moving windows that would be hidden into visible space. Said changes will come shortly. Tested by many. matthieu@ didn't oppose.
* *sigh* Revert the diff that wasn't meant to go in yet.oga2008-09-22-117/+24
| | | | | note to self: When you mean to type cvs commit search.c, don't forget the filename.
* Display the current window title not a previous one in the case ofoga2008-09-22-24/+117
| | | | | ``show all'' in the window search dialogue. Noticed and diff from Tim van der Molen, thanks!
* move client_vertmaximize to a more sensible location, purely for readability.okan2008-07-15-20/+20
| | | | "don't mind at all" oga@
* save an X call and use what we already have stored.okan2008-07-15-9/+5
| | | | ok oga@
* don't compensate for bwidth twice.okan2008-07-15-3/+3
| | | | ok oga@
* we already have ymax, so use it instead of asking X for it again.okan2008-07-11-8/+4
| | | | ok oga@
* spacing, declaration lineup to be consistent throughout cwm,okan2008-07-11-57/+60
| | | | | | readability, and a bit of knf. ok oga@
* only cycle through visible *and* non-ignored windows.okan2008-06-30-3/+3
| | | | ok oga@
* Actually grab the correct mouse buttons for a window, instead of doing theoga2008-06-25-3/+2
| | | | | | old hardcoded ones (which now can be wrong). tested by todd@ and johan@.
* No need to map/unmap the window on hide/show since we already do theoga2008-06-18-3/+1
| | | | | | same to its parent. "makes sense" okan@.
* (mostly) proper xshape event supportokan2008-06-14-4/+1
| | | | ok oga@
* re-work client_placecalc()okan2008-06-12-45/+29
| | | | | | | - make sure new clients sit inside the current screen - respect 'gap' placement on new clients ok oga@
* make sure to take bwdith into account when placing a new window.okan2008-05-23-4/+3
| | | | ok oga@
* Pull out the behaviour in grab_label and search_start into one utilityoga2008-05-20-8/+6
| | | | | | | | | | | function menu_filter(). The plan is to eventually merge in grab_menu too. Shrinks the code a fair bit. Also, change XMaskEvent for XWindowEvent to prevent getting exposes for other windows. This is particuarly noticable on slow machines with a LOT of xterms (todd, you're an odd man). ok okan@, todd@.
* client_cyclenext() -> client_cycle() since we now pass an arg.okan2008-05-19-2/+2
| | | | | | removes a stray proto as well. discussed with and ok oga@
* Use the XGrabKeyboard hack in for alt-tabbing as well. This stops theoga2008-05-19-3/+3
| | | | | | | | | | | mru getting the order messed up when gvim/xpdf et all steal key events. While i'm here, change the logic in client_cyclenext() to use break instead of goto, it's nicer that way. Thirdly, instead of two different kbfuncs, just use the one and a flag. "put your cycle diff in so I can pkg_delete gvim" okan@
* finally implement keyboard binding for group togglingokan2008-05-19-1/+2
| | | | | | | | | | idea for the "slightly-less-abhorrent-hack-but-a-hack-nonetheless-TM" from oga@ grab and ungrab the keyboard to get around some silly X apps that like stealing events ok oga@
* remove extra calls to client_draw_border()okan2008-05-18-3/+1
| | | | ok oga@
* fix cwm's current XShape support from Edd Barrett -thanks.okan2008-05-17-16/+24
| | | | | | XShape events should be handled at some point. ok oga@
* KNF, no binary change.oga2008-05-15-5/+5
| | | | From Pierre Riteau. Thanks!
* tiny bit of knfokan2008-05-15-14/+6
| | | | ok oga@
* Rework the alt-tabbing code to be a lot simpler.oga2008-05-01-53/+31
| | | | | | | | | | Diff mostly from Edd Barrett, with some minor changes from me. Unfortunately the issue where apps like gvim and xpdf are stealing keyrelease events causing the ordering to be messed up, but this is a lot better. A fix for the aforementioned issue shall be forthcoming, once a good one's been found. ok okan@, also tested by todd@
* Remove screen_infomsg(), nothing uses it.oga2008-04-16-16/+2
| | | | ok okan.
* hit it with the knf stick.oga2008-04-15-23/+24
|
* Add "gap" support to .cwmrc. The options put in here make gaps on the edgeoga2008-04-15-11/+10
| | | | | | | | | of the screen where an application won't be {,vert}maximized over. used for placing a statusbar or something like xclock. Patch from Edd Barrett, with input from myself and okan. Thanks! ok okan@.
* remove alt-tab menuokan2008-04-09-86/+1
| | | | | | discussed with a few ok oga@
* Fix a couple of issues with the maximization code.oga2008-03-26-8/+19
| | | | | | | | | | | | If a window is vertically maximized, then resized, before the MAXIMIZED flag wasn't removed, now it is. so doing a resize then does the right thing. Also, separate flags are needed for vertical and normal maximziation, else when you do vertical-maximize, followed by maximize, the window returns to it's original size. ok simon@, okan@
* Rip out, burn, and dance around the grave of group-edit mode.oga2008-03-22-5/+2
| | | | | | | | | | | I've yet to speak to anyone who uses it, so just kill it. You can still add/remove from groups using the mouse binding. Groups may get a re-work sometime soon if i have a stroke of genius. knocks about 4k off the i386 binary for me. ok okan@, todd@.
* As mentioned in my last commit, there was an issue where the switchingoga2008-03-19-5/+9
| | | | | | | | code would always assume that the number of windows to switch to was three if there were more windows hidden. Check for CLIENT_HIDDEN when we count. Now it counts correctly. ok simon@.
* huge amount of cleanup and dead code removal.oga2008-01-16-37/+1
| | | | | | | | | | | | | | | | | | | | | | | | | full description of changes: -remove fontlist, and all associated structures/calls, it's not needed. this also removes any doubt about leftover 9wm code (the list was borrowed from it). Since cwm now uses Xft for everything, the legacy font handling is just not needed. -add /* FALLTHROUGH */ comments into grab_{label,menu}. I actually didn't intend grab_menu to be a fallthrough, but it actually works quite well there, so remove the extra rectangle drawing. I love it when that happens. -remove a couple of unused prototypes that were obviously missed before. -remove a bunch of commented out or if 0ed out code. It doesn't look to be coming back anytime soon. -several functions returned an int, but this was never checked. most of them only failed if they failed to grab the pointer (thus the internal state didn't change), so just make them void and return early if this is the case. -remove several unused functions and some useless variables. knocks something like 200bytes off the stripped binary size for me. ok marc@, tested by several others.
* - Remove the "all rights reserved" tag at the top of most of the sourceoga2008-01-11-2/+13
| | | | | | | | | | | | | | | | | | files, and replace them with the actual ISC license. - add license to the manpage (it was lacking before) - correct license statement in the README Permission given by Marius (copyright holder): "1. please replace with the standard ISC license 2. you may add the ISC license to the man page 3. feel free to replace the information in the README as well" and Dros (copyright holder for group.c): "Please switch group.c to the ISC License." ok ian@
* Adjust initial window placement with any geometry that would placemarc2008-01-03-4/+7
| | | | | the window at or over the right or bottom edge. OK oda@