aboutsummaryrefslogtreecommitdiffstats
path: root/client.c (unfollow)
Commit message (Collapse)AuthorLines
2013-12-12ICCCM explicitly states that server time (CurrentTime) should *not* beokan-5/+8
used for focus events, but rather the timestamp of the generated event. Track the last event timestamp and send it down for a WM_TAKE_FOCUS ClientMessage. I suspect we should do this for clients that don't announce this Atom as well, though the raciness gets us into a bind. Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@ ok sthen@
2013-12-11we don't need to manage the save-set since we're not reparenting; left-over ↵okan-3/+1
from pwin
2013-12-11since we are drawing in unhide, no need to during client setupokan-2/+1
2013-12-11apply mwm hints laterokan-4/+4
2013-12-11Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotifyokan-8/+12
events; based off a diff from Thomas Adam.
2013-12-11Remove extra work and simplify client state handling.okan-14/+35
2013-12-11Stash Class and WM Hints in client_ctxokan-22/+17
2013-12-10Redraw client border when unhiding; during a hide, we just unsetokan-1/+2
the active flag but never redraw since it'll be in IconicState. Behaviour reported by sthen@
2013-11-27alter -r1.145 getsizehints to deal with clients that don't haveokan-36/+30
WM_NORMAL_HINTS.
2013-11-27simplify/unfoldokan-6/+4
2013-11-27Rewrite active/inactive client handling in client_setactive();okan-51/+29
client_leave() served no real purpose, likewise no reason to handle LeaveNotify events since an EnterNotify will process the next active client (and we don't have anything important to process anyway), so xev_handle_leavenotify() goes as well. Allows a simplification of client_mtf() and client_cycle_leave() for clarity. While here, unify a few client_current() checks. No intended behaviour change.
2013-11-12Alter the r1.35 of event.c race fix. Remove the forward looking eventokan-11/+2
queue check (removing the need for a server grab/ungrab) - if the client is going away, let it fall all the way through to a DestroyNotify event. There's no longer a need for us to manually destroy a client ourselves (removing yet another server grab/ungrab). Instead, when the UnmapNotify event is synthetic, simply set the state to Withdrawn (as per ICCCM), else Iconic (in our case 'hidden'). Verified with test case from the 2009 race which was the original reason for r1.35 of event.c.
2013-11-11Put back the border draw call in client_resize; since we are adding andokan-1/+3
removing the border on maximized clients we need to redraw. Also noticed by Tim van der Molen
2013-11-08stash WMProtocols in flagsokan-6/+6
2013-11-05quick keyboard focus fix for clients that neither populate wmhints nor ↵okan-2/+3
wmprotocols, like rdesktop; focus needs to be re-visited
2013-11-02The only reason we need to keep XSizeHints in our client_ctx is forokan-31/+38
flags, so just add one to hints; consolidates sizehints and shrinks. Additionally don't abuse PSize for XGetWMNormalHints() failures.
2013-11-01x/y from XSizeHints are obsolete (and have been for a long time), sookan-5/+3
instead use x/y from XWindowAttributes when USPosition|PPosition are set.
2013-11-01re-add support for WM_TAKE_FOCUS, and additionally this time only callokan-9/+18
XSetInputFocus() for clients that have the InputHint; latter fix discovered by Valery Masiutsin with a PoC patch - solves keyboard input focus loss for java apps.
2013-10-25A client_delete should behave differently depending on whether theokan-8/+10
triggering event was unmap (with pending destroy) log destroy; we only need to grab/ungrab the server lock, set WithdrawnState and XRemoveFromSaveSet clients coming from an unmap event - doing so for clients coming from destroy are already gone, hence we generate errors.
2013-10-20revert 1.138 (WM_TAKE_FOCUS) for nowokan-3/+1
2013-10-19Using xu_btn_ungrab() buttons during client_leave doesn't work (errorokan-6/+1
BadValue) when the modifier is already AnyModifier . Instead alter xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a client is coming into focus in client_setactive(), instead of iterating over ignore mods - matches how we handle key grabs.
2013-10-19I believe we redraw the border in too many cases; likely a leftover fromokan-4/+1
the cc->pwin days - don't redraw on every unhide, resize, and mouse move/resize Expose event (note, all Expose events trigger a redraw anyway). Tested with some finicky X apps I could think of, though I'm sure others will find more - if so, and they 'lose' the border, please report!
2013-10-19For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, sendokan-1/+3
a ClientMessage event.
2013-10-03unify type; no changeokan-2/+2
2013-07-15collapse linesokan-3/+2
2013-07-15simplify atom handling; allows us to limit to one round-trip to serverokan-7/+7
for gathering Atoms.
2013-06-10move synthetic responses and have client_msg only work with WM_PROTOCOLS,okan-6/+41
since that's all ClientMessageEvent is for anyway.
2013-05-23alter conf_grab(_kbd) to first ungrab AnyKey/AnyModifier, then proceedokan-2/+2
to grab keys in keybindingq. we don't need to ungrab/grab on every addition to the queue, just once with a complete keybindingq; simplify grabbing keys per screen (during init) and during a MappingNotify. while here, change conf_grab_{kbd,mouse} to require only a Window.
2013-05-20add support for _NET_WM_STATE_MAXIMIZED_{HORZ,VERT}; from Alexander Polakov.okan-1/+6
while I'm unsure of the final look of _NET_WM_STATE, there's no reason to delay this support.
2013-05-19- switch border colors to Xftokan-5/+5
- merge border/menu color structures/functions since they now both use Xft - switch xu_xorcolor to operating on XftColor instead of just XRenderColor (basically adding pixel) - if color name allocation fails, revert back to default (this, along with font validation should occur during config parse, but we don't have screens setup yet - likely to change at some point)
2013-05-19use XGetWMProtocols and simplify WM_PROTOCOL handlingokan-19/+16
2013-05-11new -> initokan-2/+2
2013-05-06remove group in client_delete directly.okan-4/+4
2013-04-17mechanical xu_{get,set}state -> xu_{get,set}_wm_state changeokan-6/+6
2013-04-17slightly rework WM_STATE set/get to make it less ambigious; will be more clearokan-8/+12
on what needs to change to make it right in the end.
2013-04-14only a window is required to set WM_STATE. also un-confuse xu_ptr_getposokan-2/+2
by using 'win' instead of 'rootwin' so as not to imply only the root window is queried, rather any window.
2013-04-12we handle WM_STATE here, so remove misleading comment.okan-2/+1
2013-04-12we already set window state in client_hide or client_unhide right before, sookan-2/+1
there's no need to do it again.
2013-04-05zap stray whitespaceokan-3/+3
2013-04-03- no reason to breakout ClassHints work, so fold into client_{new,delete},okan-24/+16
but keep _MOTIF_WM_HINTS separate. - simplify fetching app/class hint. - fix _MOTIF_WM_HINTS Atom type.
2013-04-03move XUngrabServer to the end of client_new() to avoid races where clients,okan-4/+4
such as those using sdl, attempt to manage the clients themselves when the clients aren't fully ready. other wm's grab the xserver during the whole client setup process, so match. behavior found by jsg.
2013-01-08add per-group vert/horiz tiling support; introduces 2 new bind commands,okan-1/+119
'vtile' and 'htile'; from Alexander Polakov.
2013-01-08teach screen_find_xinerama() about gap and adjust (simplify) callers;okan-23/+12
menu becomes gap-aware for free.
2013-01-07fix menu/client placement in panning setups; XineramaQueryScreens givesokan-1/+3
us the width of the psuedo screen, but here we need the edge instead (xmax/ymax); just re-use w/h here for now.
2013-01-06use cc->bwidth in client_vmax since we've yet to reset it (matchesokan-2/+2
client_hmax); from Jan Stary
2013-01-04rename {h,v}max functions for consistency; from Jan Staryokan-3/+3
2013-01-04get rid of struct colorokan-5/+5
2013-01-02re-work client_snapcalc() so it takes client and edge dimensions withokan-9/+7
snapdist; allows for simplier snap calculations. required for an upcoming diff for honoring gap.
2013-01-02have screen_find_xinerama() return struct geom *reliably* instead ofokan-65/+27
XineramaScreenInfo; simplifies goop around the callers.
2013-01-02more variable consistencyokan-21/+21
powered by cgit and git | oriole.systems | how to verify signatures