aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Make sure we really take work area gap into account with snap calculations;okan2013-12-12-6/+6
| | | | from Dominik Honnef via Christian Neukirchen.
* ICCCM explicitly states that server time (CurrentTime) should *not* beokan2013-12-12-9/+16
| | | | | | | | | | | used for focus events, but rather the timestamp of the generated event. Track the last event timestamp and send it down for a WM_TAKE_FOCUS ClientMessage. I suspect we should do this for clients that don't announce this Atom as well, though the raciness gets us into a bind. Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@ ok sthen@
* we don't need to manage the save-set since we're not reparenting; left-over ↵okan2013-12-11-3/+1
| | | | from pwin
* since we are drawing in unhide, no need to during client setupokan2013-12-11-2/+1
|
* apply mwm hints laterokan2013-12-11-4/+4
|
* Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotifyokan2013-12-11-10/+18
| | | | events; based off a diff from Thomas Adam.
* Remove extra work and simplify client state handling.okan2013-12-11-49/+41
|
* Stash Class and WM Hints in client_ctxokan2013-12-11-32/+27
|
* Redraw client border when unhiding; during a hide, we just unsetokan2013-12-10-1/+2
| | | | | | the active flag but never redraw since it'll be in IconicState. Behaviour reported by sthen@
* If not using sticky mode (the default), clients aren't automagicallyokan2013-12-08-5/+5
| | | | | assigned a group, thus cc->group will be NULL - fix the client group shortcut in menu lists; crash reported by Christian Neukirchen.
* When we receive a NotionNotify event, there's no need to (incorrectlyokan2013-12-02-4/+1
| | | | might I add) redraw the top menu selection.
* Always highlight the first menu item (helpful to see selected items whenokan2013-12-02-5/+3
| | | | | not using a mouse and therefore not generating Expose/MotionNotify events); from Thomas Adam.
* Prepend the group shortcut in the client search menu; from Thomas Adam.okan2013-12-02-5/+6
| | | | Likewise, prepend shortcut in unhide menu.
* Since we use IconicState as our hidden state, check for the hidden flagokan2013-12-02-3/+5
| | | | | | | | and unmanage the client if we're not hidden (basically if NormalState) during an UnmapNotify event. Resolves an issue with mplayer going fullscreen while not using NetWM hints; behaviour regression reported by Ido Admon.
* like gap, make snapdist per screenokan2013-11-27-8/+10
|
* alter -r1.145 getsizehints to deal with clients that don't haveokan2013-11-27-36/+30
| | | | WM_NORMAL_HINTS.
* Remove the option to bind a key by keycode with brackets; it neverokan2013-11-27-25/+10
| | | | | | | worked (and no one complained!). While it's fairly easy to fix, users should be using keysym names and not keycodes. Discussed at length months ago with todd@, matthieu@ and Owain.
* simplify/unfoldokan2013-11-27-13/+9
|
* Rewrite active/inactive client handling in client_setactive();okan2013-11-27-73/+38
| | | | | | | | | | | client_leave() served no real purpose, likewise no reason to handle LeaveNotify events since an EnterNotify will process the next active client (and we don't have anything important to process anyway), so xev_handle_leavenotify() goes as well. Allows a simplification of client_mtf() and client_cycle_leave() for clarity. While here, unify a few client_current() checks. No intended behaviour change.
* Log message:benno2013-11-25-6/+6
| | | | | | use u_char for buffers in yylex, for ctype calls, as done in all other parse.y in the tree found by millert@, ok okan@
* Alter the r1.35 of event.c race fix. Remove the forward looking eventokan2013-11-12-30/+9
| | | | | | | | | | | | queue check (removing the need for a server grab/ungrab) - if the client is going away, let it fall all the way through to a DestroyNotify event. There's no longer a need for us to manually destroy a client ourselves (removing yet another server grab/ungrab). Instead, when the UnmapNotify event is synthetic, simply set the state to Withdrawn (as per ICCCM), else Iconic (in our case 'hidden'). Verified with test case from the 2009 race which was the original reason for r1.35 of event.c.
* Put back the border draw call in client_resize; since we are adding andokan2013-11-11-1/+3
| | | | | | removing the border on maximized clients we need to redraw. Also noticed by Tim van der Molen
* stash WMProtocols in flagsokan2013-11-08-13/+9
|
* quick keyboard focus fix for clients that neither populate wmhints nor ↵okan2013-11-05-2/+3
| | | | wmprotocols, like rdesktop; focus needs to be re-visited
* The only reason we need to keep XSizeHints in our client_ctx is forokan2013-11-02-33/+40
| | | | | flags, so just add one to hints; consolidates sizehints and shrinks. Additionally don't abuse PSize for XGetWMNormalHints() failures.
* x/y from XSizeHints are obsolete (and have been for a long time), sookan2013-11-01-5/+3
| | | | | instead use x/y from XWindowAttributes when USPosition|PPosition are set.
* re-add support for WM_TAKE_FOCUS, and additionally this time only callokan2013-11-01-10/+20
| | | | | | XSetInputFocus() for clients that have the InputHint; latter fix discovered by Valery Masiutsin with a PoC patch - solves keyboard input focus loss for java apps.
* A client_delete should behave differently depending on whether theokan2013-10-25-13/+15
| | | | | | | triggering event was unmap (with pending destroy) log destroy; we only need to grab/ungrab the server lock, set WithdrawnState and XRemoveFromSaveSet clients coming from an unmap event - doing so for clients coming from destroy are already gone, hence we generate errors.
* shuffleokan2013-10-20-38/+38
|
* wrap key ungrab like btn ungrab, for it'll be used againokan2013-10-20-4/+11
|
* revert 1.138 (WM_TAKE_FOCUS) for nowokan2013-10-20-3/+1
|
* Using xu_btn_ungrab() buttons during client_leave doesn't work (errorokan2013-10-19-15/+9
| | | | | | | BadValue) when the modifier is already AnyModifier . Instead alter xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a client is coming into focus in client_setactive(), instead of iterating over ignore mods - matches how we handle key grabs.
* I believe we redraw the border in too many cases; likely a leftover fromokan2013-10-19-13/+4
| | | | | | | | | the cc->pwin days - don't redraw on every unhide, resize, and mouse move/resize Expose event (note, all Expose events trigger a redraw anyway). Tested with some finicky X apps I could think of, though I'm sure others will find more - if so, and they 'lose' the border, please report!
* For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, sendokan2013-10-19-1/+3
| | | | a ClientMessage event.
* a few err->errx since we don't have error messages here; from Tiago Cunhaokan2013-10-17-7/+7
|
* trying parsing a XLFD string first, then by patternokan2013-10-07-4/+7
|
* unify type; no changeokan2013-10-03-10/+10
|
* we no longer need to construct an array for _NET_SUPPORTED.okan2013-07-16-8/+2
|
* don't need the size hereokan2013-07-16-2/+2
|
* max -> nitemsokan2013-07-16-8/+8
|
* shuffle down protoypesokan2013-07-15-51/+48
|
* collapse linesokan2013-07-15-13/+9
|
* simplify atom handling; allows us to limit to one round-trip to serverokan2013-07-15-101/+95
| | | | for gathering Atoms.
* bring buttonpress and keypress event handlers slightly closer togetherokan2013-07-10-9/+8
|
* type fixesokan2013-07-10-5/+5
|
* since the root and event window are the same in the case of a buttonokan2013-07-09-9/+6
| | | | | | | event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen.
* add support for mouse based group {,r}cycle; from Rodrigo Mosconi. notokan2013-07-08-5/+27
| | | | bound by default.
* move kbfunc and mousefunc closer togetherokan2013-07-08-57/+61
|
* clarify kbd vs mouse functionsokan2013-07-08-23/+23
|
* move duplicate kbd and mouse modifier parsing to a generic function;okan2013-07-08-35/+31
| | | | from Tiago Cunha
powered by cgit and git | oriole.systems | how to verify signatures