| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
|
| |
If a client is killed and the cursor lands in the root window, no client
is focused. Attempting to cycle back to the last focused client will
instead focus the previous-to-last. Add specific checks that make sure
the cursor is positioned where the user expects it to be. This patch was
taken from a bug report on openbsd-misc [1].
[1] https://marc.info/?l=openbsd-tech&m=155931484124288&w=2
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As cwm was using the screen's default visual and colormap to draw all
client borders, borders for windows that had a depth of 32 bits were not
rendered correctly. The same happened with text in the popup menus which
were recently changed to be drawn in the context of the client.
This commit introduces a Visual reference for each client, and allocates
all potential colors for a client's specific visual and colormap in the
client_ctx struct. These colors are then used to draw client borders and
popup menus.
Additionally, since we touch the drawing code anyway, borders are
reintroduced to the popup menus for better contrast.
|
|
|
|
|
|
| |
These loops never freed cargs and cargs->cmd from bind_ctx. Instead of
adding more calls to free() manually, replace the whole loops with the
conf_unbind_* functions which free the struct properly.
|
|
|
|
|
| |
The previous size calculation did not account for the prompt characters
(0xc2 0xbb and 0xc2 0xab respectively).
|
|
|
|
|
| |
Obscure feature. Confusing if you don't know about it, mostly useless if
you do. Matching on currently visible window titles is enough.
|
|
|
|
|
|
|
|
| |
Whilst arguably useful for certain people, or in rare cases, this
functionality is not needed in the general case.
This will also remove a memory leak where fallback was not properly
freed.
|
|
|
|
|
|
| |
There is no point in keeping this functionality. Saving a few key
strokes is not worth the added complexity of the window manager parsing
the known_hosts file.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a couple of issues I found with this functionality:
1) To my knowledge, it is undocumented and extremely specific.
2) Since this function would only complete a full path (by wrapping it
in quotes before passing it on), it is entirely useless when composing a
command that has more than one argument.
3) The snprintf call has no check for truncation, possibly leading to
the path not being quoted properly.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Original file locations in the OpenBSD tree:
- lib/libc/stdlib/reallocarray.c
- lib/libc/stdlib/strtonum.c
- lib/libc/string/strlcat.c
- lib/libc/string/strlcpy.c
- sys/sys/queue.h
|
|
|
|
|
|
|
| |
This reverts commit 603548105b9bf9ffd11eb053e62db99f9433e821.
Using u_char instead of char will generate signedness warnings for
strtonum(), lookup(), and xstrdup().
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spawn a window, maximize it in any way, move the cursor to a window border
that is not on the screen's edge and unmaximize again: While the window
goes back the cursor stays at the screen's edge, i.e. focus is lost to the
underlaying window.
Moving, resizing, tiling or snapping windows in any way always moves the
cursor along iff needed, e.g. using MS-[hjkl] to move a small window from
the center to the edge keeps the cursor within window borders -- no matter
what you do with the keyboard, focus stays on that window.
Make CM-f, CM-m, CM-equal and CMS-equal (default bindings) for toggling
full-screen mode, maximization, vertical maximization and horizontal
maximization of the current window drag the cursor along if needed as well.
OK okan kmos dv
|
|
|
|
|
|
|
| |
If a client calls XSetTextProperty for a window to clear all its
properties, then allocated memory within libX11 is not freed.
OK okan@
|
|
|
|
|
|
|
|
|
|
| |
quoted arguments are stored for other window managers.
The quotation handling happens within the while loop without checking if
the "end" limit has been already reached. If this happens, the final
NULL assignment leads to an out of boundary write on stack.
OK okan@
|
|
|
|
| |
htile/vtile actions. From Uwe Werler, with a few manpage tweaks.
|
| |
|
|
|
|
| |
determine what client to set active. Reduces a round trip for every window.
|
| |
|
|
|
|
| |
OK okan@
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
From and OK okan@
Original commit message:
Plug two memory leaks. Also get rid of a variable that is no longer
necessary.
OK okan@
|
| |
|
|
|
|
| |
OK okan@ schwarze@
|
|
|
|
| |
OK okan@
|
| |
|
|
|
|
| |
dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
|
|
|
|
| |
Behaviour (or lack there of) noticed by Raf Czlonka.
|
|
|
|
| |
From Artturi Alm (though changed from 'm' to '5')
|
| |
|
|
|
|
| |
reported by Stefan Hagen.
|
|
|
|
|
|
| |
client), there's a window of time where an expose or enternotify event will get generated for a lower client; use a hammer and drain events after keyboard move/resize, until such a time that cwm doesn't warp the pointer. Behavior noticed by kn.
ok kn@
|
|
|
|
| |
potential for a use-after-free (true!) where kn@ ran into the regression using an app that actually exercised the XGrabPointer() failure path.
|
|
|
|
|
|
|
|
|
|
| |
Link what is described as "applications" here to how they are actually
defined in cwmrc(5).
While here, call the configuration file what it is instead of reusing
the default path (already mentioned in the FILES section).
OK okan
|
|
|
|
| |
util.c:u_exec() has been doing so since import.
|
| |
|
|
|
|
|
|
|
| |
This fixes the problem where cwm's window menu wouldn't show Firefox's current
window title if it contains non-ASCII characters.
OK okan@
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
buttonpress handler; bail if we don't manage the screen. Allows us to find the
current client based on the screen/event root.
|