From 9dd67272ed57e8923510197eb5ac8d3f819fbb26 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Sun, 27 Jul 2014 20:50:59 +0200 Subject: Always check if README exists in choose_readme() Specifying a nonexistent README file via the readme option is sometimes useful, e.g. when using scan-path and setting a global default. Currently, we check whether there is only one option in the readme option and, if so, we choose that file without checking whether it exists. As a consequence, all repositories are equipped with an about link in the aforementioned scenario, even if there is no about file. Remove the early check for the number of keys and always check whether the file exists instead. Signed-off-by: Lukas Fleischer --- cgit.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/cgit.c b/cgit.c index 20f6e27..8c4517d 100644 --- a/cgit.c +++ b/cgit.c @@ -504,12 +504,6 @@ static void choose_readme(struct cgit_repo *repo) free(ref); continue; } - /* If there's only one item, we skip the possibly expensive - * selection process. */ - if (repo->readme.nr == 1) { - found = 1; - break; - } if (ref) { if (cgit_ref_path_exists(filename, ref, 1)) { found = 1; -- cgit v1.2.3-2-gb3c3